Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1763883003: [DevTools] Fix compiler errors in bindings module (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prepare-ui-module
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix compiler errors in bindings module BUG=591865 R=lushnikov@chromium.org Committed: https://crrev.com/3053098da46ad929bbebfdb914203eeddd3fdfdd Cr-Commit-Position: refs/heads/master@{#379240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 4 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1760093003 Patch 20001

Dependent Patchsets:

Issue 1761243002 Patch 1
Issue 1761243002 Patch 60001

Messages

Total messages: 10 (4 generated)
kozy
ptal
4 years, 9 months ago (2016-03-04 02:54:18 UTC) #1
lushnikov
lgtm
4 years, 9 months ago (2016-03-04 03:29:57 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1760093003 Patch 20001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-04 03:49:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763883003/1
4 years, 9 months ago (2016-03-04 06:12:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:36:10 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:37:23 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3053098da46ad929bbebfdb914203eeddd3fdfdd
Cr-Commit-Position: refs/heads/master@{#379240}

Powered by Google App Engine
This is Rietveld 408576698