Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1760093003: [DevTools] Prepare UI module for closure compiler roll (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-array-from
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Prepare UI module for closure compiler roll BUG=591865 R=lushnikov@chromium.org Committed: https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf Cr-Commit-Position: refs/heads/master@{#379215}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 4 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1765733002 Patch 1

Dependent Patchsets:

Issue 1763883003 Patch 1

Messages

Total messages: 12 (5 generated)
kozy
ptal
4 years, 9 months ago (2016-03-04 00:28:19 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/1760093003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right): https://codereview.chromium.org/1760093003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js#newcode283 third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:283: * @return {!Promise<{detail: string, description: string}>|!Promise<undefined>} use null ...
4 years, 9 months ago (2016-03-04 00:42:44 UTC) #2
kozy
All done https://codereview.chromium.org/1760093003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right): https://codereview.chromium.org/1760093003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js#newcode283 third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:283: * @return {!Promise<{detail: string, description: string}>|!Promise<undefined>} On ...
4 years, 9 months ago (2016-03-04 00:50:11 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1765733002 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-04 00:50:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760093003/20001
4 years, 9 months ago (2016-03-04 03:49:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 04:55:54 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 04:56:57 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf
Cr-Commit-Position: refs/heads/master@{#379215}

Powered by Google App Engine
This is Rietveld 408576698