Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prepare-bindings-module
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix compile errors before closure compiler roll BUG=591865 R=lushnikov@chromium.org Committed: https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad Cr-Commit-Position: refs/heads/master@{#379295}

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1763883003 Patch 1

Messages

Total messages: 10 (4 generated)
kozy
ptal!
4 years, 9 months ago (2016-03-04 04:51:36 UTC) #1
lushnikov
lgtm! https://codereview.chromium.org/1761243002/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js File third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js (right): https://codereview.chromium.org/1761243002/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js#newcode898 third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js:898: this._requests.push({ time: endTime, screenshots: screenshots }); it should ...
4 years, 9 months ago (2016-03-04 05:06:58 UTC) #2
kozy
All done :) https://codereview.chromium.org/1761243002/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js File third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js (right): https://codereview.chromium.org/1761243002/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js#newcode898 third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js:898: this._requests.push({ time: endTime, screenshots: screenshots }); ...
4 years, 9 months ago (2016-03-04 06:13:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761243002/60001
4 years, 9 months ago (2016-03-04 15:09:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 9 months ago (2016-03-04 16:17:33 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:18:45 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad
Cr-Commit-Position: refs/heads/master@{#379295}

Powered by Google App Engine
This is Rietveld 408576698