Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 1763883003: [DevTools] Fix compiler errors in bindings module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prepare-ui-module
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
index a848f1a8549fded057d40b0031014aa855109dd4..98fc9c29eebbd6d256d323c13490c2b18290a30b 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
@@ -116,7 +116,7 @@ WebInspector.BlackboxManager.prototype = {
if (!mappings.length) {
if (previousScriptState.length > 0)
- return this._setScriptState(script, []).then(this._sourceMapLoadedForTest);
+ return this._setScriptState(script, []);
}
var currentBlackboxed = false;
@@ -128,13 +128,13 @@ WebInspector.BlackboxManager.prototype = {
currentBlackboxed = true;
}
for (var mapping of mappings) {
- if (currentBlackboxed !== this.isBlackboxedURL(mapping.sourceURL)) {
+ if (mapping.sourceURL && currentBlackboxed !== this.isBlackboxedURL(mapping.sourceURL)) {
positions.push({ line: mapping.lineNumber, column: mapping.columnNumber });
currentBlackboxed = !currentBlackboxed;
}
isBlackboxed = currentBlackboxed || isBlackboxed;
}
- return this._setScriptState(script, !isBlackboxed ? [] : positions).then(this._sourceMapLoadedForTest);
+ return this._setScriptState(script, !isBlackboxed ? [] : positions);
/**
* @param {!WebInspector.SourceMap.Entry} a
* @param {!WebInspector.SourceMap.Entry} b
@@ -148,11 +148,6 @@ WebInspector.BlackboxManager.prototype = {
}
},
- _sourceMapLoadedForTest: function()
- {
- // This method is sniffed in tests.
- },
-
/**
* @param {!WebInspector.UISourceCode} uiSourceCode
* @return {?string}
@@ -268,7 +263,7 @@ WebInspector.BlackboxManager.prototype = {
.then(loadSourceMap.bind(this, script)));
}
}
- Promise.all(promises).then(this._patternChangeFinishedForTests);
+ Promise.all(promises).then(this._patternChangeFinishedForTests.bind(this));
/**
* @param {!WebInspector.Script} script
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698