Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1763743002: Revert of add support for new bitmapshader context (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add support for new bitmapshader context (patchset #5 id:80001 of https://codereview.chromium.org/1757993002/ ) Reason for revert: oops, need to update bench to know about the large size needed for the new shader Original issue's description: > add support for new bitmapshader context > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757993002 > > Committed: https://skia.googlesource.com/skia/+/19cef56344b5a5f26f802d7be34c44af36b7e797 TBR=herb@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cd660e1c07371d9cf97824245639b1c0b5ac92fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -118 lines) Patch
M gm/SkLinearBitmapPipelineGM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 5 chunks +21 lines, -101 lines 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of add support for new bitmapshader context
4 years, 9 months ago (2016-03-03 17:36:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763743002/1
4 years, 9 months ago (2016-03-03 17:36:40 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:36:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd660e1c07371d9cf97824245639b1c0b5ac92fc

Powered by Google App Engine
This is Rietveld 408576698