git cl for Gerrit: make --squash generate Change-Id directly.

git cl for Gerrit: make --squash generate Change-Id directly.

BUG=579183
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299107

[tandrii(chromium), 2016-03-03 01:33:32]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 01:33:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/1

[commit-bot: I haz the power, 2016-03-03 01:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 01:36:13]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-03-03 02:31:58]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 02:32:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/20001

[tandrii(chromium), 2016-03-03 02:48:16]

tandrii@chromium.org changed reviewers:
+ andybons@chromium.org, phajdan.jr@chromium.org

[tandrii(chromium), 2016-03-03 02:48:16]

this CL adds logic for detection of two ChangeID messages, which is really a
safeguard, but otherwise has same logic as before, however it generates the
ChangeID itself, without the need of commit hooks.

[commit-bot: I haz the power, 2016-03-03 02:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 02:52:14]

Dry run: Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[Bons, 2016-03-03 03:19:52]

lgtm

https://codereview.chromium.org/1763593002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1763593002/diff/20001/git_cl.py#newcode2217
git_cl.py:2217: DieWithError('too many Change-Id footers in %s branch' %
shadow_branch)
is there any way to give the user more info as to what they can do to rectify
the situation?

[Paweł Hajdan Jr., 2016-03-03 10:10:51]

LGTM

[tandrii(chromium), 2016-03-04 11:55:23]

https://codereview.chromium.org/1763593002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1763593002/diff/20001/git_cl.py#newcode2217
git_cl.py:2217: DieWithError('too many Change-Id footers in %s branch' %
shadow_branch)
On 2016/03/03 03:19:52, Bons wrote:
> is there any way to give the user more info as to what they can do to rectify
> the situation?

no, because the message came from the shadow branch, that the user isn't even
supposed to touch. I'm getting rid of it in future CL, and this message will
also get somewhat refactored.

[tandrii(chromium), 2016-03-04 12:04:30]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 12:04:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/40001

[commit-bot: I haz the power, 2016-03-04 12:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 12:10:50]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-03-04 15:42:59]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 15:43:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/60001

[commit-bot: I haz the power, 2016-03-04 15:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 15:45:34]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-03-04 15:46:39]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-03-04 15:46:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1763593002/#ps60001
(title: "rebase for test fixes")

[commit-bot: I haz the power, 2016-03-04 15:46:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/60001

[tandrii(chromium), 2016-03-04 15:48:38]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-03-04 16:08:53]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-04 16:08:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763593002/60001

[commit-bot: I haz the power, 2016-03-04 16:11:33]

Description was changed from

==========
git cl for Gerrit: make --squash generate Change-Id directly.

BUG=579183
==========

to

==========
git cl for Gerrit: make --squash generate Change-Id directly.

BUG=579183

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299107
==========

[commit-bot: I haz the power, 2016-03-04 16:11:34]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299107