Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1760063002:
git cl: stop downloading Gerrit commit-hook with --squash mode. (Closed)
|
Created:
4 years, 9 months ago by tandrii(chromium) Modified:
4 years, 9 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@G0850 Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
Descriptiongit cl: stop downloading Gerrit commit-hook with --squash mode.
BUG=579176
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299117
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase for test fixes #Patch Set 5 : fix tests #Patch Set 6 : fix tests, for real this time. #Messages
Total messages: 37 (19 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/20001
tandrii@chromium.org changed reviewers: + andybons@chromium.org, phajdan.jr@chromium.org
PTAL this is the crown jewel which together will all dependent CLs This recipe is my way of verifying it end-to-end. As you can see in tryjobs for https://codereview.chromium.org/1662993002/#ps800002, 3 platforms did upload to gerrit and generated ChangeID on the fly. I'll follow this set of CLs with another one which deals with re-uploads (second patchset) as well as getting rid of shadow branch.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
lgtm
LGTM
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
tandrii@chromium.org changed reviewers: + bauerb@chromium.org
+bauerb@ as FYI
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1760063002/#ps60001 (title: "rebase for test fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1760063002/#ps80001 (title: "fix tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1760063002/#ps100001 (title: "fix tests, for real this time.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760063002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760063002/100001
Message was sent while issue was closed.
Description was changed from ========== git cl: stop downloading Gerrit commit-hook with --squash mode. BUG=579176 ========== to ========== git cl: stop downloading Gerrit commit-hook with --squash mode. BUG=579176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299117 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299117 |
