Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: tests/git_cl_test.py

Issue 1763593002: git cl for Gerrit: make --squash generate Change-Id directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@G0825
Patch Set: rebase for test fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index f1cee8a2793c340ec45ccd13eaa1ab4f78483096..e4a412b79130df78a95dff617f7626b0107a73a6 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -17,6 +17,7 @@ from testing_support.auto_stub import TestCase
import git_cl
import git_common
+import git_footers
import subprocess2
class PresubmitMock(object):
@@ -588,7 +589,7 @@ class TestGitCl(TestCase):
'fake_ancestor_sha..HEAD'],),
description)
]
- if git_cl.CHANGE_ID not in description:
+ if not git_footers.get_footer_change_id(description) and not squash:
calls += [
((['git', 'log', '--pretty=format:%s\n\n%b',
'fake_ancestor_sha..HEAD'],),
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698