Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761743002: git cl upload for Gerit no-squash: correct detect missing Change-Id. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@G0800
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl upload for Gerit no-squash: correct detect missing Change-Id. BUG=579183 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299105

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M git_cl.py View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M tests/git_cl_test.py View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M tests/git_footers_test.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1764453002 Patch 80001

Dependent Patchsets:

Issue 1763593002 Patch 60001

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761743002/40001
4 years, 9 months ago (2016-03-03 02:32:13 UTC) #2
tandrii(chromium)
slight refactoring to make sure Change-Id is really present as a proper footer.
4 years, 9 months ago (2016-03-03 02:49:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/523)
4 years, 9 months ago (2016-03-03 02:54:44 UTC) #6
Bons
lgtm
4 years, 9 months ago (2016-03-03 03:17:28 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-03 10:10:05 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761743002/60001
4 years, 9 months ago (2016-03-04 12:04:38 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/536)
4 years, 9 months ago (2016-03-04 12:15:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761743002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761743002/80001
4 years, 9 months ago (2016-03-04 15:42:33 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:44:50 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299105

Powered by Google App Engine
This is Rietveld 408576698