Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now detects version mismatch before creating a QUIC session and sends out a version negotiation packet at that point. Protected by --Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame. received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003

Committed: https://crrev.com/33407f13bfd05bc2614fd063bcbc6ad38904ad24
Cr-Commit-Position: refs/heads/master@{#379375}

[danzh1, 2016-03-04 05:41:04]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 05:41:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761263002/1

[danzh1, 2016-03-04 05:50:24]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

Deprecate --gfe2_reloadable_flag_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221

Deprecate gfe2_reloadable_flag_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862

Make QUIC version negotiation stateless. The QUIC dispatcher now detects version
mismatch before creating a QUIC session and sends out a version negotiation
packet at that point. Protected by --Flag_quic_stateless_version_negotiation

Merge internal change: 115603675

Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435

Remove single line virtual methods that are not overridden anywhere.

n/a (QUIC client)

Merge internal change: 115591067

n/a (QUIC toy client/server)

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866

waiting for PackeReader


Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160

Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic

Cut-over from old to new BalsaUrl/HttpRequest interfaces.  See CL
113648771 for extended discussion of this change.  No functional change
intended, not flag-protected.

Merge internal change: 115455799

n/a (QUIC toy client/server changes)

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705

Remove an unused declaration of QuicAckNotifier.

n/a (unused declaration)

Merge internal change: 115400573

Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

As suggested by birenroy@ in b/27248264:

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186

Deprecate --gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288

Remove unnecessary ReadPacket method.

Merge internal change: 115339832

Deprecate --gfe2_reloadable_flag_quic_supports_trailers

Merge internal change: 115244730

Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444

QuicSession::CreateIncomingDynamicStream now retains ownership of the created
stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980

BUG=
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAG_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221

relnote: Deprecate --FLAG_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client

Merge internal change: 115591067

relnote: QUIC toy client/server

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160

relnote: Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic

Cut-over from old to new BalsaUrl/HttpRequest interfaces.  See CL
113648771 for extended discussion of this change.  No functional change
intended, not flag-protected.

Merge internal change: 115455799

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832

relnote: Deprecate --gfe2_reloadable_flag_quic_supports_trailers

Merge internal change: 115244730

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
==========

[commit-bot: I haz the power, 2016-03-04 06:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 06:27:24]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[danzh1, 2016-03-04 15:30:24]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAG_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221

relnote: Deprecate --FLAG_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client

Merge internal change: 115591067

relnote: QUIC toy client/server

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160

relnote: Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic

Cut-over from old to new BalsaUrl/HttpRequest interfaces.  See CL
113648771 for extended discussion of this change.  No functional change
intended, not flag-protected.

Merge internal change: 115455799

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832

relnote: Deprecate --gfe2_reloadable_flag_quic_supports_trailers

Merge internal change: 115244730

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No functio change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

[danzh1, 2016-03-04 15:31:56]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No functio change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

[danzh1, 2016-03-04 15:42:53]

danzh@chromium.org changed reviewers:
+ rch@chromium.org

[danzh1, 2016-03-04 15:53:28]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 15:53:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761263002/40001

[commit-bot: I haz the power, 2016-03-04 16:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 16:43:00]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[danzh1, 2016-03-04 20:23:01]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 20:23:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761263002/60001

[Ryan Hamilton, 2016-03-04 20:59:11]

lgtm, but please fix the name of the flag in the cl description.

[danzh1, 2016-03-04 21:06:29]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate
--gfe2_reloadable_flag_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

[danzh1, 2016-03-04 21:06:59]

On 2016/03/04 20:59:11, Ryan Hamilton wrote:
> lgtm, but please fix the name of the flag in the cl description.

done.

[commit-bot: I haz the power, 2016-03-04 21:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:50:25]

Dry run: This issue passed the CQ dry run.

[danzh1, 2016-03-04 21:51:33]

The CQ bit was checked by danzh@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:51:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1761263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1761263002/60001

[commit-bot: I haz the power, 2016-03-04 21:58:24]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

[commit-bot: I haz the power, 2016-03-04 21:58:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-04 22:00:16]

Description was changed from

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003
==========

to

==========
Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5.

relnote: Deprecate --FLAGS_quic_use_stream_sequencer_buffer.

Merge internal change: 115699221
https://codereview.chromium.org/1764913002/#ps20001

relnote: Deprecate --FLAGS_enable_quic_fec.

Disable the ability to enable FEC protection via connection options.
First change to remove FEC.

Merge internal change: 115690862
https://codereview.chromium.org/1766623002/#ps20001

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now
detects version mismatch before creating a QUIC session and sends out a version
negotiation packet at that point. Protected by
--Flag_quic_stateless_version_negotiation

Merge internal change: 115603675
https://codereview.chromium.org/1761253002/#ps20001

relnote: Reserve exactly enough space for QUIC timestamps in QuicAckFrame.
received_packet_times.  No functional change.

Merge internal change: 115591435
https://codereview.chromium.org/1760973003/#ps20001

relnote: Remove single line virtual methods that are not overridden anywhere.

QUIC client change.

Merge internal change: 115591067
https://codereview.chromium.org/1761643004/#ps20001

relnote: QUIC toy client/server change

Replace custom client packet reading code with call to
QuicPacketReader::ReadAndDispatchSinglePacket

Merge internal change: 115551866
https://codereview.chromium.org/1760423002/#ps20001

relnote: Remove virtual keyword from QuicSpdyStream::WriteTrailers.

Merge internal change: 115456160
https://codereview.chromium.org/1745303003/#ps40001

relnote: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No function change.

Merge internal change: 115455799
https://codereview.chromium.org/1749303002/#ps40001

relnote: QUIC toy client/server changes

Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing
client/server CreateUDPSocket methods to be a bit more descriptive.

Merge internal change: 115444705
https://codereview.chromium.org/1752823002/#ps40001

relnote: Remove an unused declaration of QuicAckNotifier.

Merge internal change: 115400573
https://codereview.chromium.org/1751923003/#ps40001

relnote: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed
implementations, No functional change.

Added a new visitor interface method to the SpdyFramerVisitorInterface
with signature:

  virtual void OnStreamEnd(SpdyStreamId stream_id) = 0;

Stubbed the new method in all implementors.

The eventual goal is to use the new method to handle stream ends
consistently, removing the need for fin boolean arguments in the other
methods in the visitor.

Merge internal change: 115370186
https://codereview.chromium.org/1749203002/#ps40001

relnote: Deprecate --FLAGS_quic_distinguish_incoming_outgoing_streams.

Merge internal change: 115342288
https://codereview.chromium.org/1755663002#ps60001

relnote: Remove unnecessary ReadPacket method.

Merge internal change: 115339832
https://codereview.chromium.org/1750303003/#ps60001

relnote: Deprecate --FLAGS_quic_supports_trailers

Merge internal change: 115244730
https://codereview.chromium.org/1753453003

relnote: Add 3 Quic e2e tests of server push. No behavior change.

Merge internal change: 115228444
https://codereview.chromium.org/1746803003

relnote: QuicSession::CreateIncomingDynamicStream now retains ownership of the
created stream. No functional change.

Adds the ActivateStream call to CreateIncomingDynamicStream, which makes
it behave in a similar way to CreateOutgoingDynamicStream. Both methods
now retain ownership of the created stream (ActivateStream adds it to
the dynamic_stream_map_).

Merge internal change: 115218980
https://codereview.chromium.org/1744103003

Committed: https://crrev.com/33407f13bfd05bc2614fd063bcbc6ad38904ad24
Cr-Commit-Position: refs/heads/master@{#379375}
==========

[commit-bot: I haz the power, 2016-03-04 22:00:17]

Patchset 4 (id:??) landed as
https://crrev.com/33407f13bfd05bc2614fd063bcbc6ad38904ad24
Cr-Commit-Position: refs/heads/master@{#379375}