Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1744103003: QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional… (Closed)

Created:
4 years, 9 months ago by danzh1
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Robbie Shade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QuicSession::CreateIncomingDynamicStream now retains ownership of the created stream. No functional change. Adds the ActivateStream call to CreateIncomingDynamicStream, which makes it behave in a similar way to CreateOutgoingDynamicStream. Both methods now retain ownership of the created stream (ActivateStream adds it to the dynamic_stream_map_). Merge internal change: 115218980 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M net/quic/p2p/quic_p2p_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1746803003 Patch 1

Messages

Total messages: 9 (4 generated)
danzh1
4 years, 9 months ago (2016-02-29 19:00:48 UTC) #1
Ryan Hamilton
lgtm
4 years, 9 months ago (2016-02-29 19:39:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744103003/1
4 years, 9 months ago (2016-03-04 14:32:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744103003/1
4 years, 9 months ago (2016-03-04 17:03:42 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 17:46:57 UTC) #9 
Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

Powered by Google App Engine
This is Rietveld 408576698