Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: net/tools/quic/quic_server_session_base_test.cc

Issue 1761263002: Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ActivateStream() call to QuicChromiumClientSession to fix server push failure Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_server_session_base.cc ('k') | net/tools/quic/quic_simple_client_bin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_server_session_base_test.cc
diff --git a/net/tools/quic/quic_server_session_base_test.cc b/net/tools/quic/quic_server_session_base_test.cc
index cab373774aeac3130996c848b20269874248107b..1d4ed11647055d006ffe6486576c569222f5924e 100644
--- a/net/tools/quic/quic_server_session_base_test.cc
+++ b/net/tools/quic/quic_server_session_base_test.cc
@@ -83,7 +83,9 @@ class TestServerSession : public QuicServerSessionBase {
if (!ShouldCreateIncomingDynamicStream(id)) {
return nullptr;
}
- return new QuicSimpleServerStream(id, this);
+ QuicSpdyStream* stream = new QuicSimpleServerStream(id, this);
+ ActivateStream(stream);
+ return stream;
}
QuicSpdyStream* CreateOutgoingDynamicStream(SpdyPriority priority) override {
@@ -325,27 +327,6 @@ TEST_P(QuicServerSessionBaseTest, GetStreamDisconnected) {
"ShouldCreateIncomingDynamicStream called when disconnected");
}
-TEST_P(QuicServerSessionBaseTest, SetFecProtectionFromConfig) {
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_fec, true);
-
- // Set received config to have FEC connection option.
- QuicTagVector copt;
- copt.push_back(kFHDR);
- QuicConfigPeer::SetReceivedConnectionOptions(session_->config(), copt);
- session_->OnConfigNegotiated();
-
- // Verify that headers stream is always protected and data streams are
- // optionally protected.
- EXPECT_EQ(
- FEC_PROTECT_ALWAYS,
- QuicSpdySessionPeer::GetHeadersStream(session_.get())->fec_policy());
- ReliableQuicStream* stream =
- QuicServerSessionBasePeer::GetOrCreateDynamicStream(session_.get(),
- kClientDataStreamId1);
- ASSERT_TRUE(stream);
- EXPECT_EQ(FEC_PROTECT_OPTIONAL, stream->fec_policy());
-}
-
class MockQuicCryptoServerStream : public QuicCryptoServerStream {
public:
explicit MockQuicCryptoServerStream(
« no previous file with comments | « net/tools/quic/quic_server_session_base.cc ('k') | net/tools/quic/quic_simple_client_bin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698