Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: net/tools/quic/quic_client_session_test.cc

Issue 1761263002: Landing recent QUIC changes until 7:19 PM, Feb 26, 2016 UTC-5. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ActivateStream() call to QuicChromiumClientSession to fix server push failure Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_session.cc ('k') | net/tools/quic/quic_client_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client_session_test.cc
diff --git a/net/tools/quic/quic_client_session_test.cc b/net/tools/quic/quic_client_session_test.cc
index b6cae3945b47ab9a213365568fa009be7cf52fab..ac65bf5998316296f3c481394d3a6813978f4a4b 100644
--- a/net/tools/quic/quic_client_session_test.cc
+++ b/net/tools/quic/quic_client_session_test.cc
@@ -69,7 +69,9 @@ class TestQuicClientSession : public QuicClientSession {
MockQuicSpdyClientStream* CreateIncomingDynamicStream(
QuicStreamId id) override {
- return new MockQuicSpdyClientStream(id, this);
+ MockQuicSpdyClientStream* stream = new MockQuicSpdyClientStream(id, this);
+ ActivateStream(stream);
+ return stream;
}
};
@@ -231,28 +233,6 @@ TEST_P(QuicClientSessionTest, GoAwayReceived) {
EXPECT_EQ(nullptr, session_->CreateOutgoingDynamicStream(kDefaultPriority));
}
-TEST_P(QuicClientSessionTest, SetFecProtectionFromConfig) {
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_fec, true);
-
- // Set FEC config in client's connection options.
- QuicTagVector copt;
- copt.push_back(kFHDR);
- session_->config()->SetConnectionOptionsToSend(copt);
-
- // Doing the handshake should set up FEC config correctly.
- CompleteCryptoHandshake();
-
- // Verify that headers stream is always protected and data streams are
- // optionally protected.
- EXPECT_EQ(
- FEC_PROTECT_ALWAYS,
- QuicSpdySessionPeer::GetHeadersStream(session_.get())->fec_policy());
- QuicSpdyClientStream* stream =
- session_->CreateOutgoingDynamicStream(kDefaultPriority);
- ASSERT_TRUE(stream);
- EXPECT_EQ(FEC_PROTECT_OPTIONAL, stream->fec_policy());
-}
-
static bool CheckForDecryptionError(QuicFramer* framer) {
return framer->error() == QUIC_DECRYPTION_FAILURE;
}
« no previous file with comments | « net/tools/quic/quic_client_session.cc ('k') | net/tools/quic/quic_client_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698