Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1761153002: Replace ChildController with ShellClientFactory (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@29binding
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ChildController with ShellClientFactory BUG= Committed: https://crrev.com/f733e3aa4dc62af9eaeaf9947040b8b9b132c663 Cr-Commit-Position: refs/heads/master@{#379310}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -210 lines) Patch
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 5 6 3 chunks +0 lines, -22 lines 0 comments Download
M mojo/shell/application_manager.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download
M mojo/shell/native_runner.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/names.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/public/interfaces/application_manager.mojom View 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/runner/child/BUILD.gn View 1 2 3 4 2 chunks +0 lines, -13 lines 0 comments Download
D mojo/shell/runner/child/child_controller.mojom View 1 2 3 4 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/shell/runner/child/runner_connection.cc View 1 5 chunks +7 lines, -18 lines 0 comments Download
M mojo/shell/runner/host/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/host/child_process.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/runner/host/child_process_base.cc View 1 4 chunks +6 lines, -17 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 1 2 3 4 5 3 chunks +11 lines, -16 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 1 2 3 4 5 4 chunks +16 lines, -45 lines 0 comments Download
M mojo/shell/runner/host/child_process_host_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.cc View 1 2 3 chunks +13 lines, -13 lines 0 comments Download
M mojo/shell/tests/application_manager/driver.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1761113002 Patch 1

Messages

Total messages: 10 (5 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-04 02:54:37 UTC) #3
sky
LGTM
4 years, 9 months ago (2016-03-04 16:31:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761153002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761153002/120001
4 years, 9 months ago (2016-03-04 17:46:52 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-04 18:06:28 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 18:08:19 UTC) #10
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/f733e3aa4dc62af9eaeaf9947040b8b9b132c663
Cr-Commit-Position: refs/heads/master@{#379310}

Powered by Google App Engine
This is Rietveld 408576698