Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1761113002: Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rath… (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@28lifecycle2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Monitor the ShellClient binding for pipe closure as a signal to shut down the ShellConnection, rather than the first Connector InterfacePtr. R=sky@chromium.org BUG= Committed: https://crrev.com/e0a35bdf06354d3cd9e1160e61873509877ff00e Cr-Commit-Position: refs/heads/master@{#379180}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-03 22:56:17 UTC) #1
sky
LGTM
4 years, 9 months ago (2016-03-04 00:08:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761113002/1
4 years, 9 months ago (2016-03-04 00:53:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 02:08:56 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 02:11:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0a35bdf06354d3cd9e1160e61873509877ff00e
Cr-Commit-Position: refs/heads/master@{#379180}

Powered by Google App Engine
This is Rietveld 408576698