mojo/shell/runner/host/child_process_host_unittest.cc - Issue 1761153002: Replace ChildController with ShellClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/runner/host/child_process_host_unittest.cc

Issue 1761153002: Replace ChildController with ShellClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@29binding

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/runner/host/child_process_host_unittest.cc

diff --git a/mojo/shell/runner/host/child_process_host_unittest.cc b/mojo/shell/runner/host/child_process_host_unittest.cc

index e14d2ac2fe785271ed17ff1cfc3c43d58af62e0f..9209115d7daa61f4ee699e1119a0e54ef9eb59f5 100644

--- a/mojo/shell/runner/host/child_process_host_unittest.cc

+++ b/mojo/shell/runner/host/child_process_host_unittest.cc

@@ -99,10 +99,7 @@ TEST(ChildProcessHostTest, MAYBE_StartJoin) {

base::Bind(&ProcessReadyCallbackAdapater, run_loop.QuitClosure()));

run_loop.Run();

- child_process_host.ExitNow(123);

- int exit_code = child_process_host.Join();

- VLOG(2) << "Joined child: exit_code = " << exit_code;

- EXPECT_EQ(123, exit_code);

+ child_process_host.Join();

blocking_pool->Shutdown();

edk::ShutdownIPCSupport();

EXPECT_EQ(1u, native_runner_delegate.get_and_clear_adjust_count());