Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: content/browser/mojo/mojo_shell_client_host.cc

Issue 1761153002: Replace ChildController with ShellClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@29binding
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/mojo_shell.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/mojo/mojo_shell_client_host.cc
diff --git a/content/browser/mojo/mojo_shell_client_host.cc b/content/browser/mojo/mojo_shell_client_host.cc
index 0bdd217e713f0ea6923b63214ace3648d5a31df3..e972cdb3a1c9d8e208ca520172af53c6d53120a5 100644
--- a/content/browser/mojo/mojo_shell_client_host.cc
+++ b/content/browser/mojo/mojo_shell_client_host.cc
@@ -118,10 +118,12 @@ std::string RegisterChildWithExternalShell(
GetProxy(&pid_receiver);
new PIDSender(render_process_host, std::move(pid_receiver));
- application_manager->CreateInstanceForHandle(
- mojo::ScopedHandle(mojo::Handle(request_pipe.release().value())),
- url,
- CreateCapabilityFilterForRenderer(),
+ mojo::shell::mojom::ShellClientFactoryPtr factory;
+ factory.Bind(mojo::InterfacePtrInfo<mojo::shell::mojom::ShellClientFactory>(
+ std::move(request_pipe), 0u));
+
+ application_manager->CreateInstanceForFactory(
+ std::move(factory), url, CreateCapabilityFilterForRenderer(),
std::move(request));
// Store the URL on the RPH so client code can access it later via
« no previous file with comments | « no previous file | mojo/mojo_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698