CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

src/objects.h

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 417411d15524222bfb59708acd5b9a6f8589e24d..b1189dc0f4a3c7355c7098e6546c3948616bd43b 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5755,7 +5755,7 @@ class Script: public Struct {
   DECL_ACCESSORS(name, Object)
 
   // [id]: the script id.
-  DECL_ACCESSORS(id, Object)
+  DECL_ACCESSORS(id, Smi)
 
   // [line_offset]: script line offset in resource from where it was extracted.
   DECL_ACCESSORS(line_offset, Smi)
@@ -5820,6 +5820,7 @@ class Script: public Struct {
   static const int kEvalFrominstructionsOffsetOffset =
       kEvalFromSharedOffset + kPointerSize;
   static const int kSize = kEvalFrominstructionsOffsetOffset + kPointerSize;
+  static const int kNoScriptId = 0;

[Jakob Kummerow, 2013/06/25 11:58:39]

Please move this somewhere else (e.g. to the beginning of the class definition,
by the enums), as it has nothing to do with the object layout description.
Since this only has a single use in api.cc, it would also be fine with me to
just inline the value (maybe as a function-local constant to be more descriptive
than a plain '0' literal).

[loislo, 2013/06/25 13:04:53]

It was moved to v8::Script.

 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Script);