test/cctest/test-api.cc - Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index e417477adeb427db745d93a1d33afda3dfd77024..06a6d42e41b015e144019e6cb622bebad444f74a 100755

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -16654,8 +16654,8 @@ THREADED_TEST(FunctionGetScriptId) {

env->Global()->Get(v8::String::New("foo")));

v8::Local<v8::Function> bar = v8::Local<v8::Function>::Cast(

env->Global()->Get(v8::String::New("bar")));

- CHECK_EQ(script->Id(), foo->GetScriptId());

- CHECK_EQ(script->Id(), bar->GetScriptId());

+ CHECK_EQ(script->GetId(), foo->ScriptId());

yurys 2013/06/25 11:57:38 We should keep old tests as well until the API is

+ CHECK_EQ(script->GetId(), bar->ScriptId());

}

« src/objects.h ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »