CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5737 matching lines @@
     COMPILATION_STATE_COMPILED = 1
   };
 
   // [source]: the script source.
   DECL_ACCESSORS(source, Object)
 
   // [name]: the script name.
   DECL_ACCESSORS(name, Object)
 
   // [id]: the script id.
-  DECL_ACCESSORS(id, Object)
+  DECL_ACCESSORS(id, Smi)
 
   // [line_offset]: script line offset in resource from where it was extracted.
   DECL_ACCESSORS(line_offset, Smi)
 
   // [column_offset]: script column offset in resource from where it was
   // extracted.
   DECL_ACCESSORS(column_offset, Smi)
 
   // [data]: additional data associated with this script.
   DECL_ACCESSORS(data, Object)
@@ skipping 44 matching lines @@
   static const int kTypeOffset = kWrapperOffset + kPointerSize;
   static const int kCompilationTypeOffset = kTypeOffset + kPointerSize;
   static const int kCompilationStateOffset =
       kCompilationTypeOffset + kPointerSize;
   static const int kLineEndsOffset = kCompilationStateOffset + kPointerSize;
   static const int kIdOffset = kLineEndsOffset + kPointerSize;
   static const int kEvalFromSharedOffset = kIdOffset + kPointerSize;
   static const int kEvalFrominstructionsOffsetOffset =
       kEvalFromSharedOffset + kPointerSize;
   static const int kSize = kEvalFrominstructionsOffsetOffset + kPointerSize;
+  static const int kNoScriptId = 0;

[Jakob Kummerow, 2013/06/25 11:58:39]

Please move this somewhere else (e.g. to the beginning of the class definition,
by the enums), as it has nothing to do with the object layout description.
Since this only has a single use in api.cc, it would also be fine with me to
just inline the value (maybe as a function-local constant to be more descriptive
than a plain '0' literal).

[loislo, 2013/06/25 13:04:53]

It was moved to v8::Script.

 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Script);
 };
 
 
 // List of builtin functions we want to identify to improve code
 // generation.
 //
 // Each entry has a name of a global object property holding an object
@@ skipping 3895 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_