CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

src/heap.h

Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index 3192630a012d682635b2a960cfed04ae7ad4c6d5..f843af5930d6e4081b28b6b07730c48cdf07aa1e 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -175,7 +175,7 @@ namespace internal {
   V(Code, js_entry_code, JsEntryCode)                                          \
   V(Code, js_construct_entry_code, JsConstructEntryCode)                       \
   V(FixedArray, natives_source_cache, NativesSourceCache)                      \
-  V(Object, last_script_id, LastScriptId)                                      \
+  V(Smi, last_script_id, LastScriptId)                                         \

[yurys, 2013/06/25 11:57:38]

Why not make it simple int property and probably move into Factory?

[loislo, 2013/06/25 13:04:53]

factory is a memberless class. So it cannot be used for storing last_script_id. 

   V(Script, empty_script, EmptyScript)                                         \
   V(Smi, real_stack_limit, RealStackLimit)                                     \
   V(NameDictionary, intrinsic_function_names, IntrinsicFunctionNames)        \
@@ -1441,7 +1441,7 @@ class Heap {
   }
 
   // Update the next script id.
-  inline void SetLastScriptId(Object* last_script_id);
+  inline void SetLastScriptId(int last_script_id);

[Jakob Kummerow, 2013/06/25 11:58:39]

I don't think we need this any more, since AFAICT you removed the only call site
in factory.cc.

[loislo, 2013/06/25 13:04:53]

Done.

[loislo, 2013/06/25 13:04:53]

Done.

 
   // Generated code can embed this address to get access to the roots.
   Object** roots_array_start() { return roots_; }