Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1755473004: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
brettw, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use bundle_data and create_bundle to add support for iOS app bundle. BUG=297668 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/0c9a78092183069d7293588f0639beb887bdd533

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look. This depends on my changes to tools/gn landing first and then ...
4 years, 9 months ago (2016-03-01 19:31:54 UTC) #2
Dirk Pranke
lgtm, assuming the design gets signed-off on (see comments in the spec and assuming brett ...
4 years, 9 months ago (2016-03-01 23:36:43 UTC) #4
sdefresne
Design was signed-off by brettw, implemented and shipped. Landing.
4 years, 9 months ago (2016-03-11 16:47:38 UTC) #5
Dirk Pranke
On 2016/03/11 16:47:38, sdefresne wrote: > Design was signed-off by brettw, implemented and shipped. Landing. ...
4 years, 9 months ago (2016-03-11 16:50:13 UTC) #6
sdefresne
Committed patchset #2 (id:40001) manually as 0c9a78092183069d7293588f0639beb887bdd533 (presubmit successful).
4 years, 9 months ago (2016-03-11 16:52:09 UTC) #8
jungshik at Google
4 years, 9 months ago (2016-03-11 20:31:17 UTC) #9
Message was sent while issue was closed. 
On 2016/03/11 16:52:09, sdefresne wrote:
> Committed patchset #2 (id:40001) manually as
> 0c9a78092183069d7293588f0639beb887bdd533 (presubmit successful).

sorry that icu is still in flux. (it should be over shortly once my IDN CL is
reviewed and landed in trunk). 

Anyway, this CL (fixing in master) is good. Thank you for that. 

I'll port this CL to icu's m49 branch. Then, you (or I) can roll icu in DEPS to
that revision.

Powered by Google App Engine
This is Rietveld 408576698