Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-typos
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "bundle_data" target as first step for adding bundle support to gn. The "bundle_data" target is a type of target that has no output (just a stamp) but list files that need to be present in any bundle that depend on it (generally application or frameworks that link with code that use the files at runtime) and where they should be copied into the bundle. Design: https://docs.google.com/document/d/1bKh57hg6TSBsEmeh0zWpOO5SVGA2INu-D3FGgsyICzk/view BUG=297668 Committed: https://crrev.com/db6b992c5baaf258d1a7b9687743a93eb13ac54a Cr-Commit-Position: refs/heads/master@{#379300}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -5 lines) Patch
M tools/gn/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/action_values.cc View 1 chunk +4 lines, -1 line 0 comments Download
A tools/gn/bundle_data_target_generator.h View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/gn/bundle_data_target_generator.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M tools/gn/command_desc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/functions.h View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/functions_target.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M tools/gn/gn.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A tools/gn/ninja_bundle_data_target_writer.h View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/gn/ninja_bundle_data_target_writer.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M tools/gn/substitution_type.h View 2 chunks +12 lines, -0 lines 0 comments Download
M tools/gn/substitution_type.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M tools/gn/target.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/target.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/target_generator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M tools/gn/toolchain.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look. First of three CL adding support for bundle to GN tool.
4 years, 9 months ago (2016-03-01 19:11:11 UTC) #2
brettw
lgtm
4 years, 9 months ago (2016-03-02 00:47:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751903003/40001
4 years, 9 months ago (2016-03-04 15:52:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 16:32:28 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:33:42 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db6b992c5baaf258d1a7b9687743a93eb13ac54a
Cr-Commit-Position: refs/heads/master@{#379300}

Powered by Google App Engine
This is Rietveld 408576698