Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: BUILD.gn

Issue 1755473004: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5009b50e1f5bbe80ea873e56588a951d30f12c1c..adfa81f119bca4daa5857b70212283158a52e88d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -557,10 +557,9 @@ if (is_android) {
# TODO(GYP) support use_system_icu.
if (icu_use_data_file) {
if (is_ios) {
- group("icudata") {
- # TODO(GYP): Provide an empty group so that this target does not
- # unconditionally fail. The dat file needs to be bundled separately. In
- # the longer term, need to figure out how to use system ICU
+ bundle_data("icudata") {
+ sources = [ "source/data/in/icudtl.dat" ]
+ outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
}
} else {
copy("icudata") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698