Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1753953002: Add new countDeprecationCrossOriginIframe for deprecated counters (Closed)

Created:
4 years, 9 months ago by jww
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, michaeln, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine, tommyw+watchlist_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new countDeprecationCrossOriginIframe for deprecated counters Several use counters for deprecated features were incorrectly calling countCrossOriginIframe, which will hit an ASSERT failure in debug builds since it expects an empty deprecation message. This adds a countDeprecationCrossOriginIframe method to call instead, which counts the deprecated feature with the appropriate deprecation counters. BUG=588931 Committed: https://crrev.com/137275d44f3f5f3ca58c8b655602266092e438d3 Cr-Commit-Position: refs/heads/master@{#378833}

Patch Set 1 #

Patch Set 2 : Fix lack-of-deprecation-msg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
jww
4 years, 9 months ago (2016-03-01 21:51:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-02 10:49:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753953002/1
4 years, 9 months ago (2016-03-02 16:47:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/190336)
4 years, 9 months ago (2016-03-02 17:54:45 UTC) #7
jww
4 years, 9 months ago (2016-03-02 19:49:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753953002/20001
4 years, 9 months ago (2016-03-02 19:49:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 21:18:04 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 21:19:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/137275d44f3f5f3ca58c8b655602266092e438d3
Cr-Commit-Position: refs/heads/master@{#378833}

Powered by Google App Engine
This is Rietveld 408576698