Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1753953002: Add new countDeprecationCrossOriginIframe for deprecated counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix lack-of-deprecation-msg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 65f6557d7f49423e8b70a9ddeb444881b0fbeb22..1af294921bbf979b48e91c2e4f39db75c77f7371 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -151,6 +151,18 @@ void Deprecation::countDeprecationIfNotPrivateScript(v8::Isolate* isolate, Execu
Deprecation::countDeprecation(context, feature);
}
+void Deprecation::countDeprecationCrossOriginIframe(const Document& document, UseCounter::Feature feature)
+{
+ LocalFrame* frame = document.frame();
+ if (!frame)
+ return;
+ // Check to see if the frame can script into the top level document.
+ SecurityOrigin* securityOrigin = frame->securityContext()->securityOrigin();
+ Frame* top = frame->tree().top();
+ if (top && !securityOrigin->canAccess(top->securityContext()->securityOrigin()))
+ countDeprecation(frame, feature);
+}
+
String Deprecation::deprecationMessage(UseCounter::Feature feature)
{
switch (feature) {
@@ -277,6 +289,7 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
return "The deviceorientationabsolute event is deprecated on insecure origins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
case UseCounter::GeolocationInsecureOrigin:
+ case UseCounter::GeolocationInsecureOriginIframe:
// TODO(jww): This message should be made less ambigous after WebView
// is fixed so geolocation can be removed there. After that, this
// should be updated to read similarly to GetUserMediaInsecureOrigin's
@@ -284,6 +297,7 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
return "getCurrentPosition() and watchPosition() are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
case UseCounter::GetUserMediaInsecureOrigin:
+ case UseCounter::GetUserMediaInsecureOriginIframe:
return "getUserMedia() no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
case UseCounter::EncryptedMediaInsecureOrigin:

Powered by Google App Engine
This is Rietveld 408576698