third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp - Issue 1753953002: Add new countDeprecationCrossOriginIframe for deprecated counters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

Issue 1753953002: Add new countDeprecationCrossOriginIframe for deprecated counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix lack-of-deprecation-msg Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp ('k') | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

diff --git a/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp b/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

index fb2e8a710af31492b54b46eb339cfbb9fefd7830..416b1b4782cc7ab46efa9442cfce7ca17ff9160b 100644

--- a/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

+++ b/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

@@ -127,7 +127,7 @@ void ApplicationCacheHost::selectCacheWithManifest(const KURL& manifestURL)

UseCounter::countCrossOriginIframe(*document, UseCounter::ApplicationCacheManifestSelectSecureOrigin);

} else {

Deprecation::countDeprecation(document, UseCounter::ApplicationCacheManifestSelectInsecureOrigin);

- UseCounter::countCrossOriginIframe(*document, UseCounter::ApplicationCacheManifestSelectInsecureOrigin);

+ Deprecation::countDeprecationCrossOriginIframe(*document, UseCounter::ApplicationCacheManifestSelectInsecureOrigin);

OriginsUsingFeatures::countAnyWorld(*document, OriginsUsingFeatures::Feature::ApplicationCacheManifestSelectInsecureOrigin);

}

if (m_host && !m_host->selectCacheWithManifest(manifestURL)) {