Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.h

Issue 1753953002: Add new countDeprecationCrossOriginIframe for deprecated counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix lack-of-deprecation-msg Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef Deprecation_h 5 #ifndef Deprecation_h
6 #define Deprecation_h 6 #define Deprecation_h
7 7
8 #include "core/CSSPropertyNames.h" 8 #include "core/CSSPropertyNames.h"
9 #include "core/CoreExport.h" 9 #include "core/CoreExport.h"
10 #include "core/frame/UseCounter.h" 10 #include "core/frame/UseCounter.h"
(...skipping 23 matching lines...) Expand all
34 // 34 //
35 // For shared workers and service workers, the ExecutionContext* overload 35 // For shared workers and service workers, the ExecutionContext* overload
36 // doesn't count the usage but only sends a console warning. 36 // doesn't count the usage but only sends a console warning.
37 static void countDeprecation(const LocalFrame*, UseCounter::Feature); 37 static void countDeprecation(const LocalFrame*, UseCounter::Feature);
38 static void countDeprecation(ExecutionContext*, UseCounter::Feature); 38 static void countDeprecation(ExecutionContext*, UseCounter::Feature);
39 static void countDeprecation(const Document&, UseCounter::Feature); 39 static void countDeprecation(const Document&, UseCounter::Feature);
40 // Use countDeprecationIfNotPrivateScript() instead of countDeprecation() 40 // Use countDeprecationIfNotPrivateScript() instead of countDeprecation()
41 // if you don't want to count metrics in private scripts. You should use 41 // if you don't want to count metrics in private scripts. You should use
42 // countDeprecationIfNotPrivateScript() in a binding layer. 42 // countDeprecationIfNotPrivateScript() in a binding layer.
43 static void countDeprecationIfNotPrivateScript(v8::Isolate*, ExecutionContex t*, UseCounter::Feature); 43 static void countDeprecationIfNotPrivateScript(v8::Isolate*, ExecutionContex t*, UseCounter::Feature);
44 // Count only features if they're being used in an iframe which does not
45 // have script access into the top level document.
46 static void countDeprecationCrossOriginIframe(const Document&, UseCounter::F eature);
44 static String deprecationMessage(UseCounter::Feature); 47 static String deprecationMessage(UseCounter::Feature);
45 48
46 protected: 49 protected:
47 void suppress(CSSPropertyID unresolvedProperty); 50 void suppress(CSSPropertyID unresolvedProperty);
48 bool isSuppressed(CSSPropertyID unresolvedProperty); 51 bool isSuppressed(CSSPropertyID unresolvedProperty);
49 // CSSPropertyIDs that aren't deprecated return an empty string. 52 // CSSPropertyIDs that aren't deprecated return an empty string.
50 static String deprecationMessage(CSSPropertyID unresolvedProperty); 53 static String deprecationMessage(CSSPropertyID unresolvedProperty);
51 54
52 BitVector m_cssPropertyDeprecationBits; 55 BitVector m_cssPropertyDeprecationBits;
53 }; 56 };
54 57
55 } // namespace blink 58 } // namespace blink
56 59
57 #endif // Deprecation_h 60 #endif // Deprecation_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698