Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl (Closed)

Created:
6 years, 10 months ago by dshwang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl and canvas. This makes it compatible when the video hw texture and WebGL destination texture are in different share groups. media::VideoFrame must receive multiple sync points from clients, because clients can be many. In WebGL case, only the compositor is the client of the mailbox in a frame. So we reuse MailboxHolder::sync_point as release sync point. However, media::VideoFrame has multiple clients, so media::VideoFrame must handle multiple release sync points. Let me explain the lifecycle of the mailbox of a video frame in detail, 1. The video decoder receives a new mailbox from gpu process. The video decoder doesn't insert a sync point, because all GPU operations for the mailbox already were executed in the gpu process. 2. Blink or the compositor reads the mailbox. After that, all clients must insert a release sync point. 3. When the ref count of the video frame is 0, the destructor of the video frame calls recycle callback of the video decoder. 4. The video decoder notifies reusable mailboxes to the gpu process after waiting for the release sync points. Currently, there are three providers that can make a texture type video frame: GpuVideoDecoder, RTCVideoDecoder, and VideoCapture. The video frame of VideoCapture is created in the browser process, not the gpu process. So, VideoCapture inserts a sync point before providing it to clients. BUG=127940, 350925, 362521 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267290

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cover all combinations: hw video, sw video, hw video to webgl, sw video to webgl. #

Patch Set 3 : build fix cast_unittests #

Total comments: 7

Patch Set 4 : WIP: changing SetReleaseSyncPoint() to SwapReleaseSyncPoint() #

Patch Set 5 : #

Patch Set 6 : build fix unittests #

Patch Set 7 : Add WaitSyncPoint in WMPImpl::paint(...) #

Total comments: 4

Patch Set 8 : Change VideoFrame to keep multiple release sync points. Deal with VideoCapture code also. #

Patch Set 9 : previous patchset has unrelated code by mistake. #

Total comments: 10

Patch Set 10 : Make GpuVideoAcceleratorFactories::ReadPixels() receive mailbox, instead of texture #

Total comments: 3

Patch Set 11 : build fix for android #

Patch Set 12 : remove unrelated changes #

Patch Set 13 : Focus on this CL's goal and remove wrong change #

Total comments: 20

Patch Set 14 : make mailbox in VideoFrame const #

Total comments: 2

Patch Set 15 : Remove redundant vector::clean before Vector::assign #

Patch Set 16 : Rebase to ToT #

Patch Set 17 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -102 lines) Patch
M cc/resources/video_resource_updater.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +13 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/media/video_capture_messages.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +12 lines, -11 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -1 line 0 comments Download
M media/base/video_frame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +17 lines, -3 lines 0 comments Download
M media/base/video_frame.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 11 chunks +59 lines, -15 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +38 lines, -29 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 86 (0 generated)
dshwang
6 years, 10 months ago (2014-02-21 16:30:31 UTC) #1
dshwang
https://codereview.chromium.org/175223003/diff/1/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/175223003/diff/1/content/renderer/media/webmediaplayer_impl.cc#newcode669 content/renderer/media/webmediaplayer_impl.cc:669: mailbox_holder->sync_point = web_graphics_context->insertSyncPoint(); I guess you did not insert ...
6 years, 10 months ago (2014-02-21 16:36:31 UTC) #2
danakj
I think this LGTM under the assumption that this code and the VideoResourceUpdater are running ...
6 years, 10 months ago (2014-02-21 16:39:35 UTC) #3
dshwang
On 2014/02/21 16:39:35, danakj wrote: Thank you for review. I don't fully understand your word. ...
6 years, 10 months ago (2014-02-21 17:44:49 UTC) #4
danakj
On 2014/02/21 17:44:49, dshwang wrote: > On 2014/02/21 16:39:35, danakj wrote: > Thank you for ...
6 years, 10 months ago (2014-02-21 18:25:37 UTC) #5
dshwang
On 2014/02/21 18:25:37, danakj wrote: > On 2014/02/21 17:44:49, dshwang wrote: > > On 2014/02/21 ...
6 years, 10 months ago (2014-02-21 18:55:11 UTC) #6
danakj
On Fri, Feb 21, 2014 at 1:55 PM, <dongseong.hwang@intel.com> wrote: > On 2014/02/21 18:25:37, danakj ...
6 years, 10 months ago (2014-02-21 19:06:24 UTC) #7
dshwang
Thank you for explanation. I need to investigate more deeply. let me see.... The most ...
6 years, 10 months ago (2014-02-21 19:47:31 UTC) #8
jamesr
This is inserting a sync point into a main thread context. Who's going to wait ...
6 years, 10 months ago (2014-02-21 22:15:43 UTC) #9
danakj
On 2014/02/21 22:15:43, jamesr wrote: > This is inserting a sync point into a main ...
6 years, 10 months ago (2014-02-21 22:17:58 UTC) #10
jamesr
OK. But we'll race with the compositor thread if it grabs a reference to the ...
6 years, 10 months ago (2014-02-21 22:27:46 UTC) #11
danakj
On Fri, Feb 21, 2014 at 5:27 PM, <jamesr@chromium.org> wrote: > OK. But we'll race ...
6 years, 10 months ago (2014-02-21 22:30:49 UTC) #12
jamesr
If the compositor and main thread maintained their own sync points, maybe we wouldn't need ...
6 years, 10 months ago (2014-02-21 22:36:25 UTC) #13
danakj
On Fri, Feb 21, 2014 at 5:36 PM, <jamesr@chromium.org> wrote: > If the compositor and ...
6 years, 10 months ago (2014-02-21 23:12:33 UTC) #14
dshwang
Thank you for good discussion. Now it's more clear to me. :)
6 years, 10 months ago (2014-02-22 00:46:56 UTC) #15
dshwang
Hi, I update this CL that handle all concerns of jamesr@ and danakj@. I update ...
6 years, 9 months ago (2014-02-28 17:10:35 UTC) #16
danakj
https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (left): https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc#oldcode654 content/renderer/media/webmediaplayer_impl.cc:654: web_graphics_context->waitSyncPoint(mailbox_holder->sync_point); Why is this gone? This sync point ensures ...
6 years, 9 months ago (2014-02-28 17:49:29 UTC) #17
dshwang
https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc#newcode539 content/renderer/media/webmediaplayer_impl.cc:539: skcanvas_video_renderer_.Paint(video_frame.get(), canvas, gfx_rect, alpha); On 2014/02/28 17:49:30, danakj wrote: ...
6 years, 9 months ago (2014-02-28 18:01:48 UTC) #18
dshwang
On 2014/02/28 18:01:48, dshwang wrote: > https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc#newcode695 > content/renderer/media/webmediaplayer_impl.cc:695: > video_frame->SetReleaseSyncPoint(web_graphics_context->insertSyncPoint()); > On 2014/02/28 17:49:30, ...
6 years, 9 months ago (2014-02-28 18:09:31 UTC) #19
danakj
https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc#newcode539 content/renderer/media/webmediaplayer_impl.cc:539: skcanvas_video_renderer_.Paint(video_frame.get(), canvas, gfx_rect, alpha); On 2014/02/28 18:01:48, dshwang wrote: ...
6 years, 9 months ago (2014-02-28 18:41:18 UTC) #20
dshwang
On 2014/02/28 18:41:18, danakj wrote: > https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc > File content/renderer/media/webmediaplayer_impl.cc (right): > > https://codereview.chromium.org/175223003/diff/250001/content/renderer/media/webmediaplayer_impl.cc#newcode539 > ...
6 years, 9 months ago (2014-02-28 18:54:02 UTC) #21
danakj
On Fri, Feb 28, 2014 at 1:54 PM, <dongseong.hwang@intel.com> wrote: > On 2014/02/28 18:41:18, danakj ...
6 years, 9 months ago (2014-02-28 19:09:52 UTC) #22
dshwang
On 2014/02/28 19:09:52, danakj wrote: > > https://code.google.com/p/chromium/codesearch#chromium/ > > src/content/renderer/media/renderer_gpu_video_ > > accelerator_factories.cc&rcl=1393574299&l=113 > ...
6 years, 9 months ago (2014-02-28 19:21:16 UTC) #23
no sievers
On 2014/02/28 19:21:16, dshwang wrote: > On 2014/02/28 19:09:52, danakj wrote: > > > https://code.google.com/p/chromium/codesearch#chromium/ ...
6 years, 9 months ago (2014-02-28 20:30:03 UTC) #24
dshwang
Thank you for your opinion. On 2014/02/28 20:30:03, sievers wrote: > I think you are ...
6 years, 9 months ago (2014-02-28 20:53:48 UTC) #25
danakj
On Fri, Feb 28, 2014 at 3:53 PM, <dongseong.hwang@intel.com> wrote: > Thank you for your ...
6 years, 9 months ago (2014-02-28 21:16:38 UTC) #26
dshwang
On 2014/02/28 21:16:38, danakj wrote: > > I don't mind adding glWaitSyncPoint(). All I want ...
6 years, 9 months ago (2014-02-28 21:24:14 UTC) #27
danakj
On Fri, Feb 28, 2014 at 4:24 PM, <dongseong.hwang@intel.com> wrote: > On 2014/02/28 21:16:38, danakj ...
6 years, 9 months ago (2014-02-28 21:26:16 UTC) #28
dshwang
On 2014/02/28 21:26:16, danakj wrote: > > Currently, WMPImpl::paint(..) don't wait. > > I guess ...
6 years, 9 months ago (2014-02-28 21:36:36 UTC) #29
danakj
https://codereview.chromium.org/175223003/diff/330001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/175223003/diff/330001/cc/resources/video_resource_updater.cc#newcode321 cc/resources/video_resource_updater.cc:321: // this mailbox. If below code causes critical issue, ...
6 years, 9 months ago (2014-02-28 21:47:02 UTC) #30
dshwang
https://codereview.chromium.org/175223003/diff/330001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/175223003/diff/330001/cc/resources/video_resource_updater.cc#newcode321 cc/resources/video_resource_updater.cc:321: // this mailbox. If below code causes critical issue, ...
6 years, 9 months ago (2014-02-28 21:54:16 UTC) #31
dshwang
Hi, I change VideoFrame to keep multiple release sync points. VideoFrame deals with VideoCapture code ...
6 years, 9 months ago (2014-03-03 13:14:34 UTC) #32
dshwang
On 2014/03/03 13:14:34, dshwang wrote: > Could you review again? I also improve the CL ...
6 years, 9 months ago (2014-03-03 13:15:24 UTC) #33
dshwang
On 2014/03/03 13:15:24, dshwang wrote: > On 2014/03/03 13:14:34, dshwang wrote: > > Could you ...
6 years, 9 months ago (2014-03-04 17:22:51 UTC) #34
dshwang
On 2014/03/04 17:22:51, dshwang wrote: > On 2014/03/03 13:15:24, dshwang wrote: > > On 2014/03/03 ...
6 years, 9 months ago (2014-03-06 11:44:11 UTC) #35
danakj
This looks better overall than crazy locking, thanks. https://codereview.chromium.org/175223003/diff/350001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/175223003/diff/350001/cc/resources/video_resource_updater.cc#newcode346 cc/resources/video_resource_updater.cc:346: // ...
6 years, 9 months ago (2014-03-06 19:31:30 UTC) #36
dshwang
Thank you for review. I'll address your improvement points soon. https://codereview.chromium.org/175223003/diff/350001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/175223003/diff/350001/cc/resources/video_resource_updater.cc#newcode346 ...
6 years, 9 months ago (2014-03-06 19:51:37 UTC) #37
dshwang
When I tried to address the change in renderer_gpu_video_accelerator_factories.cc, I found interesting fact. I changes ...
6 years, 9 months ago (2014-03-10 17:38:07 UTC) #38
dshwang
danajk@, can I ask a question? When two context3d is in the same process, don't ...
6 years, 9 months ago (2014-03-12 11:40:50 UTC) #39
danakj
My POV is usually "always use a sync point between contexts because that's the safest ...
6 years, 9 months ago (2014-03-12 17:15:23 UTC) #40
dshwang
danakj@, could you review again? Now I'm sure this CL is needed because of shared ...
6 years, 9 months ago (2014-03-20 08:51:15 UTC) #41
dshwang
https://codereview.chromium.org/175223003/diff/420001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/175223003/diff/420001/content/renderer/media/webmediaplayer_impl.cc#newcode687 content/renderer/media/webmediaplayer_impl.cc:687: video_frame->AppendReleaseSyncPoint(web_graphics_context->insertSyncPoint()); sievers@, I didnot add this line to webmediaplayer_android.cc, ...
6 years, 9 months ago (2014-03-20 08:53:23 UTC) #42
danakj
https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc#newcode272 content/browser/renderer_host/media/video_capture_controller.cc:272: frame->AppendReleaseSyncPoint(sync_points[i]); Do you know where is the callback that ...
6 years, 9 months ago (2014-03-20 15:59:07 UTC) #43
dshwang
https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc#newcode272 content/browser/renderer_host/media/video_capture_controller.cc:272: frame->AppendReleaseSyncPoint(sync_points[i]); That's good question. AFAIK, currently VidoeCaptureController don't create ...
6 years, 9 months ago (2014-03-20 16:11:20 UTC) #44
dshwang
Hi, could you have a time to look at this CL? Sorry for big CL. ...
6 years, 9 months ago (2014-03-24 18:16:18 UTC) #45
dshwang
On 2014/03/24 18:16:18, dshwang wrote: > Hi, could you have a time to look at ...
6 years, 8 months ago (2014-03-26 18:06:53 UTC) #46
danakj
On 2014/03/24 18:16:18, dshwang wrote: > Hi, could you have a time to look at ...
6 years, 8 months ago (2014-03-26 18:10:11 UTC) #47
Ami GONE FROM CHROMIUM
No, there should be capture paths using textures as well (e.g. desktop/tab/window capture). OnIncomingCapturedVideoFrame is ...
6 years, 8 months ago (2014-03-26 18:19:20 UTC) #48
dshwang
On 2014/03/26 18:10:11, danakj wrote: > > There are two producing methods, which creates a ...
6 years, 8 months ago (2014-03-26 18:33:26 UTC) #49
Ami GONE FROM CHROMIUM
> > On 2014/03/26 18:19:20, Ami Fischman wrote: > >> No, there should be capture ...
6 years, 8 months ago (2014-03-26 19:39:08 UTC) #50
dshwang
On 2014/03/26 19:39:08, Ami Fischman wrote: > > > > On 2014/03/26 18:19:20, Ami Fischman ...
6 years, 8 months ago (2014-03-26 20:37:13 UTC) #51
dshwang
On 2014/03/26 19:39:08, Ami Fischman wrote: > > > > On 2014/03/26 18:19:20, Ami Fischman ...
6 years, 8 months ago (2014-03-26 20:37:13 UTC) #52
danakj
LGTM https://codereview.chromium.org/175223003/diff/420001/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/175223003/diff/420001/content/renderer/media/webmediaplayer_impl.cc#newcode686 content/renderer/media/webmediaplayer_impl.cc:686: web_graphics_context->flush(); I wonder if this flush was trying ...
6 years, 8 months ago (2014-04-11 16:23:27 UTC) #53
dshwang
Thank you for review. Ami, sievers@, could you take a review content/.*/media and media/? https://codereview.chromium.org/175223003/diff/420001/content/renderer/media/webmediaplayer_impl.cc ...
6 years, 8 months ago (2014-04-11 17:55:37 UTC) #54
Ami GONE FROM CHROMIUM
I like this CL a lot! https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/175223003/diff/420001/content/browser/renderer_host/media/video_capture_controller.cc#newcode272 content/browser/renderer_host/media/video_capture_controller.cc:272: frame->AppendReleaseSyncPoint(sync_points[i]); On 2014/03/20 ...
6 years, 8 months ago (2014-04-11 20:55:16 UTC) #55
danakj
https://codereview.chromium.org/175223003/diff/420001/media/base/video_frame.cc File media/base/video_frame.cc (right): https://codereview.chromium.org/175223003/diff/420001/media/base/video_frame.cc#newcode521 media/base/video_frame.cc:521: if (!sync_point) On 2014/04/11 20:55:17, Ami Fischman wrote: > ...
6 years, 8 months ago (2014-04-14 13:19:31 UTC) #56
no sievers
On 2014/04/14 13:19:31, danakj wrote: > https://codereview.chromium.org/175223003/diff/420001/media/base/video_frame.cc > File media/base/video_frame.cc (right): > > https://codereview.chromium.org/175223003/diff/420001/media/base/video_frame.cc#newcode521 > ...
6 years, 8 months ago (2014-04-15 17:32:23 UTC) #57
no sievers
On 2014/04/15 17:32:23, sievers wrote: > On 2014/04/14 13:19:31, danakj wrote: > > > https://codereview.chromium.org/175223003/diff/420001/media/base/video_frame.cc ...
6 years, 8 months ago (2014-04-15 17:34:31 UTC) #58
Ami GONE FROM CHROMIUM
@sievers: do you make sure to avoid 0 on wrap-around? On Tue, Apr 15, 2014 ...
6 years, 8 months ago (2014-04-15 17:35:57 UTC) #59
no sievers
On 2014/04/15 17:35:57, Ami Fischman wrote: > @sievers: do you make sure to avoid 0 ...
6 years, 8 months ago (2014-04-15 17:53:48 UTC) #60
dshwang
Thank you for review, all! Sorry for not-responsible for few days. I've been OOO until ...
6 years, 8 months ago (2014-04-17 01:42:48 UTC) #61
danakj
On Wed, Apr 16, 2014 at 9:42 PM, <dongseong.hwang@intel.com> wrote: > Thank you for review, ...
6 years, 8 months ago (2014-04-17 14:24:27 UTC) #62
dshwang
Sorry for delayed response. I was ooo. Could you have a chance to review again? ...
6 years, 8 months ago (2014-04-22 19:16:50 UTC) #63
Ami GONE FROM CHROMIUM
LGTM BTW, in the future, please don't rebase while there are outstanding comments as it ...
6 years, 8 months ago (2014-04-24 01:19:49 UTC) #64
dshwang
On 2014/04/24 01:19:49, Ami Fischman wrote: > LGTM Thank you for review! > BTW, in ...
6 years, 8 months ago (2014-04-24 04:34:57 UTC) #65
dshwang
https://codereview.chromium.org/175223003/diff/440001/media/base/video_frame_unittest.cc File media/base/video_frame_unittest.cc (right): https://codereview.chromium.org/175223003/diff/440001/media/base/video_frame_unittest.cc#newcode246 media/base/video_frame_unittest.cc:246: called_sync_point->assign(release_sync_points.begin(), On 2014/04/24 01:19:50, Ami Fischman wrote: > assign ...
6 years, 8 months ago (2014-04-24 05:07:15 UTC) #66
Ami GONE FROM CHROMIUM
On Wed, Apr 23, 2014 at 9:34 PM, <dongseong.hwang@intel.com> wrote: > Ami, I guess you ...
6 years, 8 months ago (2014-04-24 06:23:54 UTC) #67
dshwang
On 2014/04/24 06:23:54, Ami Fischman wrote: > On Wed, Apr 23, 2014 at 9:34 PM, ...
6 years, 8 months ago (2014-04-24 07:04:52 UTC) #68
dshwang
On 2014/04/24 07:04:52, dshwang wrote: > On 2014/04/24 06:23:54, Ami Fischman wrote: > > On ...
6 years, 7 months ago (2014-04-26 18:48:55 UTC) #69
Cris Neckar
On 2014/04/26 18:48:55, dshwang wrote: > On 2014/04/24 07:04:52, dshwang wrote: > > On 2014/04/24 ...
6 years, 7 months ago (2014-04-28 17:45:36 UTC) #70
dshwang
On 2014/04/28 17:45:36, Cris Neckar wrote: > IPC changes LGTM Thank you for review! Finally, ...
6 years, 7 months ago (2014-04-29 13:24:26 UTC) #71
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-04-29 13:24:40 UTC) #72
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/175223003/480001
6 years, 7 months ago (2014-04-29 13:24:59 UTC) #73
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 13:28:27 UTC) #74
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium ios_rel_device on tryserver.chromium
6 years, 7 months ago (2014-04-29 13:28:28 UTC) #75
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-04-30 12:11:47 UTC) #76
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/175223003/480001
6 years, 7 months ago (2014-04-30 12:12:13 UTC) #77
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 12:16:13 UTC) #78
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 12:16:14 UTC) #79
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-04-30 13:26:53 UTC) #80
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/175223003/500001
6 years, 7 months ago (2014-04-30 13:27:07 UTC) #81
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 14:33:13 UTC) #82
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 14:33:14 UTC) #83
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-04-30 14:41:36 UTC) #84
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/175223003/500001
6 years, 7 months ago (2014-04-30 14:42:14 UTC) #85
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 19:15:32 UTC) #86
Message was sent while issue was closed.
Change committed as 267290

Powered by Google App Engine
This is Rietveld 408576698