HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl

content/renderer/media/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 665 matching lines @@
   web_graphics_context->pixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM,
                                     false);
 
   // Restore the state for TEXTURE_2D binding point as mentioned above.
   web_graphics_context->bindTexture(GL_TEXTURE_2D, texture);
 
   web_graphics_context->deleteTexture(source_texture);
 
   // The flush() operation is not necessary here. It is kept since the
   // performance will be better when it is added than not.
   web_graphics_context->flush();

[danakj, 2014/04/11 16:23:28]

I wonder if this flush was trying to deal with this issue, or what "performance"
it means now. Maybe you can revisit this flush afterwards?

[dshwang, 2014/04/11 17:55:37]

This flush is logically needed because we want to make sure gpu driver execute
WebGL's all operations when GPU video decoder context waits for below sync
point.

+  video_frame->AppendReleaseSyncPoint(web_graphics_context->insertSyncPoint());

[dshwang, 2014/03/20 08:53:24]

sievers@, I didnot add this line to webmediaplayer_android.cc, because WMPA uses
one stream texture, so it is not needed.

   return true;
 }
 
 // Helper functions to report media EME related stats to UMA. They follow the
 // convention of more commonly used macros UMA_HISTOGRAM_ENUMERATION and
 // UMA_HISTOGRAM_COUNTS. The reason that we cannot use those macros directly is
 // that UMA_* macros require the names to be constant throughout the process'
 // lifetime.
 static void EmeUMAHistogramEnumeration(const std::string& key_system,
                                        const std::string& method,
@@ skipping 626 matching lines @@
 
   if (web_cdm_) {
     decryptor_ready_cb.Run(web_cdm_->GetDecryptor());
     return;
   }
 
   decryptor_ready_cb_ = decryptor_ready_cb;
 }
 
 }  // namespace content