tools/gn/action_values.cc - Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/action_values.cc

Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-typos

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/action_values.cc

diff --git a/tools/gn/action_values.cc b/tools/gn/action_values.cc

index 819ead10c8de65456aa58aacb23b2b509706b25e..a7ce83da056447c4b84c85a2b39c55712505d643 100644

--- a/tools/gn/action_values.cc

+++ b/tools/gn/action_values.cc

@@ -15,7 +15,10 @@ ActionValues::~ActionValues() {}

void ActionValues::GetOutputsAsSourceFiles(

const Target* target,

std::vector<SourceFile>* result) const {

- if (target->output_type() == Target::COPY_FILES ||

+ if (target->output_type() == Target::BUNDLE_DATA) {

+ // The bundle_data target has no output, the real output will be generated

+ // by the create_bundle target.

+ } else if (target->output_type() == Target::COPY_FILES ||

target->output_type() == Target::ACTION_FOREACH) {

// Copy and foreach applies the outputs to the sources.

SubstitutionWriter::ApplyListToSources(

« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/bundle_data_target_generator.h » ('j') | no next file with comments »