tools/gn/target.cc - Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-typos

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index 594b368a5522911faca499e00da771da6c8413eb..9435d47ac59bfce8453c1e8216455f77f4cd27c2 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -222,6 +222,8 @@ const char* Target::GetStringForOutputType(OutputType type) {

return "Action";

case ACTION_FOREACH:

return "ActionForEach";

+ case BUNDLE_DATA:

+ return "Bundle data";

default:

return "";

}

@@ -479,6 +481,7 @@ void Target::FillOutputFiles() {

bool check_tool_outputs = false;

switch (output_type_) {

case GROUP:

+ case BUNDLE_DATA:

case SOURCE_SET:

case COPY_FILES:

case ACTION:

« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »