tools/gn/ninja_target_writer.cc - Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1751903003: Add "bundle_data" target as first step for adding bundle support to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-typos

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index 9f19b2b0065321d12f74279d97dfbe492cf5ecc1..f4de7f2247b8803c48092d91c5f761acad03e6ed 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -13,6 +13,7 @@

#include "tools/gn/filesystem_utils.h"

#include "tools/gn/ninja_action_target_writer.h"

#include "tools/gn/ninja_binary_target_writer.h"

+#include "tools/gn/ninja_bundle_data_target_writer.h"

#include "tools/gn/ninja_copy_target_writer.h"

#include "tools/gn/ninja_group_target_writer.h"

#include "tools/gn/ninja_utils.h"

@@ -57,7 +58,10 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {

std::stringstream file;

// Call out to the correct sub-type of writer.

- if (target->output_type() == Target::COPY_FILES) {

+ if (target->output_type() == Target::BUNDLE_DATA) {

+ NinjaBundleDataTargetWriter writer(target, file);

+ writer.Run();

+ } else if (target->output_type() == Target::COPY_FILES) {

NinjaCopyTargetWriter writer(target, file);

writer.Run();

} else if (target->output_type() == Target::ACTION ||

« no previous file with comments | « tools/gn/ninja_bundle_data_target_writer.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »