Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance. (Closed)

Created:
4 years, 9 months ago by nektarios
Modified:
4 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, scheib+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@renderwidgettest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Separate RenderView from RenderWidget, part 1: inheritance. (patchset #2 id:20001 of https://codereview.chromium.org/1674543004/ ) Reason for revert: Many tests are crashing on Linux-dbg https://codereview.chromium.org/1674543004 Original issue's description: > Separate RenderView from RenderWidget, part 1: inheritance. > > Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch over yet because WebTestProxy has weird templating stuff that can't support it. > > BUG=583347 > TEST=all green > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc > Cr-Commit-Position: refs/heads/master@{#378276} TBR=dcheng@chromium.org,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583347 Committed: https://crrev.com/5121a34129f274edc61a288f73f99b39eb06e1e7 Cr-Commit-Position: refs/heads/master@{#378366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -59 lines) Patch
M content/public/renderer/render_view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view_observer.cc View 2 chunks +21 lines, -14 lines 0 comments Download
M content/renderer/external_popup_menu_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 chunk +14 lines, -1 line 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_mouse_lock_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/render_widget_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
nektarios
Created Revert of Separate RenderView from RenderWidget, part 1: inheritance.
4 years, 9 months ago (2016-03-01 01:47:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750863002/1
4 years, 9 months ago (2016-03-01 01:48:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 01:48:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5121a34129f274edc61a288f73f99b39eb06e1e7 Cr-Commit-Position: refs/heads/master@{#378366}
4 years, 9 months ago (2016-03-01 01:50:05 UTC) #5
dcheng
Can you link the failing bots? I took a quick look at the waterfall, and ...
4 years, 9 months ago (2016-03-01 01:51:45 UTC) #6
chromium-reviews
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg) -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" ...
4 years, 9 months ago (2016-03-01 01:54:09 UTC) #7
dcheng
On 2016/03/01 at 01:54:09, chromium-reviews wrote: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg) > > -- > You received this ...
4 years, 9 months ago (2016-03-01 01:56:57 UTC) #8
Avi (use Gerrit)
4 years, 9 months ago (2016-03-01 05:24:45 UTC) #9
Message was sent while issue was closed.
On 2016/03/01 01:56:57, dcheng wrote:
> On 2016/03/01 at 01:54:09, chromium-reviews wrote:
> > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email to mailto:chromium-reviews+unsubscribe@chromium.org.
> > 
> > 
> 
> avi@,
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg...
> appears to be the first failing build.

Right, but that build included r378272 which was reverted. It was a Mojo patch
that appears to have exploded the world and was reverted with r378373.

Powered by Google App Engine
This is Rietveld 408576698