Separate RenderView from RenderWidget, part 1: inheritance.

Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}

Committed: https://crrev.com/8a45c109ce7d3a14111fe2c230b18ac7fcfd5d28
Cr-Commit-Position: refs/heads/master@{#378443}

[Avi (use Gerrit), 2016-02-05 20:03:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 20:07:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/1

[commit-bot: I haz the power, 2016-02-05 21:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 21:07:19]

Dry run: Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/67580)

[Avi (use Gerrit), 2016-02-22 20:38:41]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl privately inherit from RenderWidget.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation
==========

[Avi (use Gerrit), 2016-02-22 20:39:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 20:41:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/20001

[commit-bot: I haz the power, 2016-02-22 23:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 23:49:42]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-02-23 20:41:11]

avi@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-02-23 23:05:36]

lgtm with a question

https://codereview.chromium.org/1674543004/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1674543004/diff/20001/content/renderer/render...
content/renderer/render_view_impl.cc:2264: return
const_cast<RenderWidget*>(static_cast<const RenderWidget*>(this));
Is it worth importing that giant comment from render_frame_impl_browsertest.cc?

[Avi (use Gerrit), 2016-02-26 20:02:20]

https://codereview.chromium.org/1674543004/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1674543004/diff/20001/content/renderer/render...
content/renderer/render_view_impl.cc:2264: return
const_cast<RenderWidget*>(static_cast<const RenderWidget*>(this));
On 2016/02/23 23:05:35, dcheng wrote:
> Is it worth importing that giant comment from
render_frame_impl_browsertest.cc?

No, because it doesn't apply.

Those casts were to move up and down the tree because of the multiple bases.
This is a simple upcast, made complicated because we need to remove the const
and then go up.

[Avi (use Gerrit), 2016-02-26 20:20:42]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/20001

[commit-bot: I haz the power, 2016-02-26 20:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:39:09]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Avi (use Gerrit), 2016-02-29 18:36:09]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:36:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/20001

[commit-bot: I haz the power, 2016-02-29 18:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:46:32]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Avi (use Gerrit), 2016-02-29 19:59:12]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:59:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/20001

[commit-bot: I haz the power, 2016-02-29 21:18:59]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-02-29 21:19:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-29 21:21:43]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

[commit-bot: I haz the power, 2016-02-29 21:21:45]

Patchset 2 (id:??) landed as
https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}

[nektarios, 2016-03-01 01:47:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1750863002/ by nektar@chromium.org.

The reason for reverting is: Many tests are crashing on Linux-dbg
https://codereview.chromium.org/1674543004.

[Avi (use Gerrit), 2016-03-01 16:04:36]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

[Avi (use Gerrit), 2016-03-01 16:04:56]

On 2016/03/01 01:47:30, nektarios wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1750863002/ by mailto:nektar@chromium.org.
> 
> The reason for reverting is: Many tests are crashing on Linux-dbg
> https://codereview.chromium.org/1674543004.

This turned out to not be the issue; relanding.

[Avi (use Gerrit), 2016-03-01 16:05:23]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-03-01 16:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674543004/20001

[commit-bot: I haz the power, 2016-03-01 16:12:45]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

[commit-bot: I haz the power, 2016-03-01 16:12:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 16:13:36]

Description was changed from

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}
==========

to

==========
Separate RenderView from RenderWidget, part 1: inheritance.

Make RenderViewImpl able to privately inherit from RenderWidget. We can't switch
over yet because WebTestProxy has weird templating stuff that can't support it.

BUG=583347
TEST=all green
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel;tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/42e463ac3a6f667821a8bed78ba0eafde79a7bfc
Cr-Commit-Position: refs/heads/master@{#378276}

Committed: https://crrev.com/8a45c109ce7d3a14111fe2c230b18ac7fcfd5d28
Cr-Commit-Position: refs/heads/master@{#378443}
==========

[commit-bot: I haz the power, 2016-03-01 16:13:38]

Patchset 2 (id:??) landed as
https://crrev.com/8a45c109ce7d3a14111fe2c230b18ac7fcfd5d28
Cr-Commit-Position: refs/heads/master@{#378443}