content/renderer/render_frame_impl.cc - Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderwidgettest

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host_unittest.cc ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 4e3dc662ee06468ce1f01f06b00d5982d302e7c1..ae0e55896267f867ae10ea7368ee25231b872224 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -825,7 +825,7 @@

// WasShown and WasHidden, separating page-level visibility from

// frame-level visibility.

// TODO(avi): This DCHECK is to track cleanup for https://crbug.com/545684

- DCHECK_EQ(render_view->GetWidget(), render_frame->render_widget_)

+ DCHECK_EQ(render_view, render_frame->render_widget_)

<< "Main frame is no longer reusing the RenderView as its widget! "

<< "Does the RenderFrame need to register itself with the RenderWidget?";

return render_frame;

« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host_unittest.cc ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »