Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Side by Side Diff: content/public/renderer/render_view_observer.cc

Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderwidgettest
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/renderer/render_view_observer.h" 5 #include "content/public/renderer/render_view_observer.h"
6 6
7 #include "content/renderer/render_view_impl.h" 7 #include "content/renderer/render_view_impl.h"
8 8
9 using blink::WebFrame;
10
9 namespace content { 11 namespace content {
10 12
11 RenderViewObserver::RenderViewObserver(RenderView* render_view) 13 RenderViewObserver::RenderViewObserver(RenderView* render_view)
12 : render_view_(static_cast<RenderViewImpl*>(render_view)), 14 : render_view_(render_view),
13 routing_id_(MSG_ROUTING_NONE) { 15 routing_id_(MSG_ROUTING_NONE) {
14 // |render_view_| can be null on unit testing or if Observe() is used. 16 // |render_view| can be NULL on unit testing or if Observe() is used.
15 if (render_view_) { 17 if (render_view) {
16 routing_id_ = render_view_->GetRoutingID(); 18 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view);
19 routing_id_ = impl->routing_id();
17 // TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE); 20 // TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE);
18 render_view_->AddObserver(this); 21 impl->AddObserver(this);
19 } 22 }
20 } 23 }
21 24
22 RenderViewObserver::~RenderViewObserver() { 25 RenderViewObserver::~RenderViewObserver() {
23 if (render_view_) 26 if (render_view_) {
24 render_view_->RemoveObserver(this); 27 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
28 impl->RemoveObserver(this);
29 }
25 } 30 }
26 31
27 void RenderViewObserver::OnDestruct() { 32 void RenderViewObserver::OnDestruct() {
28 delete this; 33 delete this;
29 } 34 }
30 35
31 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) { 36 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) {
32 return false; 37 return false;
33 } 38 }
34 39
35 bool RenderViewObserver::Send(IPC::Message* message) { 40 bool RenderViewObserver::Send(IPC::Message* message) {
36 if (render_view_) 41 if (render_view_)
37 return render_view_->Send(message); 42 return render_view_->Send(message);
38 43
39 delete message; 44 delete message;
40 return false; 45 return false;
41 } 46 }
42 47
43 RenderView* RenderViewObserver::render_view() const { 48 RenderView* RenderViewObserver::render_view() const {
44 return render_view_; 49 return render_view_;
45 } 50 }
46 51
47 void RenderViewObserver::RenderViewGone() { 52 void RenderViewObserver::RenderViewGone() {
48 render_view_ = nullptr; 53 render_view_ = NULL;
49 } 54 }
50 55
51 void RenderViewObserver::Observe(RenderView* render_view) { 56 void RenderViewObserver::Observe(RenderView* render_view) {
52 if (render_view_) { 57 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
53 render_view_->RemoveObserver(this); 58 if (impl) {
59 impl->RemoveObserver(this);
54 routing_id_ = 0; 60 routing_id_ = 0;
55 } 61 }
56 62
57 render_view_ = static_cast<RenderViewImpl*>(render_view); 63 render_view_ = render_view;
58 if (render_view_) { 64 impl = static_cast<RenderViewImpl*>(render_view_);
59 routing_id_ = render_view_->GetRoutingID(); 65 if (impl) {
60 render_view_->AddObserver(this); 66 routing_id_ = impl->routing_id();
67 impl->AddObserver(this);
61 } 68 }
62 } 69 }
63 70
64 } // namespace content 71 } // namespace content
OLDNEW
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/renderer/external_popup_menu_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698