Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to…

Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
Committed: https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8
Cr-Commit-Position: refs/heads/master@{#379568}

[Mark Dittmer, 2016-03-01 21:18:19]

Description was changed from

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
==========

to

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
==========

[Fady Samuel, 2016-03-02 00:45:23]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 00:46:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/1

[Fady Samuel, 2016-03-02 00:47:18]

I passed your CL to the bots to verify this is indeed dead on all platforms. I
bet there's more code you can delete here.

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ImageQualityController.cpp (left):

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ImageQualityController.cpp:196:
restartTimer();
What's this timer? Can we get rid of it?

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ImageQualityController.cpp:197:
m_liveResizeOptimizationIsActive = true;
You can probably remove this.

[commit-bot: I haz the power, 2016-03-02 01:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 01:17:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Mark Dittmer, 2016-03-02 12:50:55]

Get rid of leftover inLiveResize hiding in obj-c code; eliminate
m_liveResizeOptimizationIsActive

[Mark Dittmer, 2016-03-02 12:54:56]

Mac build (hopefully) fixed. Addressed comments. fsamuel@, please give it
another run through the bots.

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ImageQualityController.cpp (left):

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ImageQualityController.cpp:196:
restartTimer();
On 2016/03/02 00:47:18, Fady Samuel wrote:
> What's this timer? Can we get rid of it?

The timer is used to toggle between lo-fi and hi-fi scrolling on Mac. I don't
think we can git rid of it. There are two restartTimer() invocations that are
independent of the live resize logic being removed.

Here:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

and here:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ImageQualityController.cpp:197:
m_liveResizeOptimizationIsActive = true;
On 2016/03/02 00:47:18, Fady Samuel wrote:
> You can probably remove this.

Done.

[Mark Dittmer, 2016-03-02 13:19:31]

markdittmer@chromium.org changed reviewers:
+ jam@chromium.org

[Mark Dittmer, 2016-03-02 13:20:38]

On 2016/03/02 12:54:56, Mark Dittmer wrote:
> Mac build (hopefully) fixed. Addressed comments. fsamuel@, please give it
> another run through the bots.
> 
>
https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/ImageQualityController.cpp (left):
> 
>
https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/ImageQualityController.cpp:196:
> restartTimer();
> On 2016/03/02 00:47:18, Fady Samuel wrote:
> > What's this timer? Can we get rid of it?
> 
> The timer is used to toggle between lo-fi and hi-fi scrolling on Mac. I don't
> think we can git rid of it. There are two restartTimer() invocations that are
> independent of the live resize logic being removed.
> 
> Here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> and here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
>
https://codereview.chromium.org/1749383002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/ImageQualityController.cpp:197:
> m_liveResizeOptimizationIsActive = true;
> On 2016/03/02 00:47:18, Fady Samuel wrote:
> > You can probably remove this.
> 
> Done.

+jam@. Hoping to eliminate dead code with this CL. PTAL.

[Fady Samuel, 2016-03-02 15:53:29]

I'd pass this to a blink owner too, Mark. Thanks!

[Mark Dittmer, 2016-03-02 17:21:11]

markdittmer@chromium.org changed reviewers:
+ jochen@chromium.org

[Mark Dittmer, 2016-03-02 17:22:16]

On 2016/03/02 15:53:29, Fady Samuel wrote:
> I'd pass this to a blink owner too, Mark. Thanks!

+jochen@, a Blink owner.

[jochen (gone - plz use gerrit), 2016-03-02 17:26:24]

lgtm

[Fady Samuel, 2016-03-02 18:17:30]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 18:18:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/20001

[commit-bot: I haz the power, 2016-03-02 18:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 18:31:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Fady Samuel, 2016-03-02 18:37:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 18:37:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/20001

[Mark Dittmer, 2016-03-02 18:47:54]

Get rid of inLiveResize from ScrollAnimatorMac

[Mark Dittmer, 2016-03-02 18:48:25]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[Mark Dittmer, 2016-03-02 18:48:42]

markdittmer@chromium.org changed reviewers:
- jam@chromium.org

[commit-bot: I haz the power, 2016-03-02 18:49:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/40001

[commit-bot: I haz the power, 2016-03-02 19:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 19:16:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-03-02 19:39:48]

Remove unnecessary ViewMsg_SetInLiveResize and associated Mac-only callbacks

[Mark Dittmer, 2016-03-02 19:41:02]

markdittmer@chromium.org changed reviewers:
+ kenrb@chromium.org

[Mark Dittmer, 2016-03-02 19:41:56]

On 2016/03/02 19:39:48, Mark Dittmer wrote:
> Remove unnecessary ViewMsg_SetInLiveResize and associated Mac-only callbacks

+kenrb@ for _messages review. Ken, PTAL; this change is subtraction of dead
code.

[Fady Samuel, 2016-03-02 19:42:35]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 19:43:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/60001

[kenrb, 2016-03-02 20:11:42]

ipc lgtm

[commit-bot: I haz the power, 2016-03-02 22:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 22:26:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-03-03 18:44:23]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 18:44:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/60001

[Mark Dittmer, 2016-03-03 20:29:40]

rebase

[Fady Samuel, 2016-03-03 20:39:16]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 20:39:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/80001

[commit-bot: I haz the power, 2016-03-03 23:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:23:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-03-03 23:24:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 23:25:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/80001

[commit-bot: I haz the power, 2016-03-04 02:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 02:27:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-03-04 16:51:39]

Resurrect obj-c callback invoked by OS X system framework

[Mark Dittmer, 2016-03-04 16:52:22]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 16:52:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/100001

[Stephen Chennney, 2016-03-04 17:36:54]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-03-04 17:36:56]

https://github.com/luisobo/Xcode-RuntimeHeaders/blob/master/DVTKit/NSScroller...

https://codereview.chromium.org/1749383002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm (left):

https://codereview.chromium.org/1749383002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm:219: -
(BOOL)inLiveResizeForScrollerImpPair:(id)scrollerImpPair
This is part of the implementation for BlinkScrollbarPainterControllerDelegate,
which is set up as the delegate for the NSScrollImpPair in the ScrollAnimatorMac
constructor. I don't think you can remove it - evidence suggests it is a
required part of the delagates implementation.

[Mark Dittmer, 2016-03-04 19:06:25]

https://codereview.chromium.org/1749383002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm (left):

https://codereview.chromium.org/1749383002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm:219: -
(BOOL)inLiveResizeForScrollerImpPair:(id)scrollerImpPair
On 2016/03/04 17:36:56, Stephen Chenney wrote:
> This is part of the implementation for
BlinkScrollbarPainterControllerDelegate,
> which is set up as the delegate for the NSScrollImpPair in the
ScrollAnimatorMac
> constructor. I don't think you can remove it - evidence suggests it is a
> required part of the delagates implementation.

Thanks. I've since added it back (with the trivial "return NO" implementation).
I'll poke around with the delegate to see whether it can be removed, but I think
you're right, probably need to keep it.

[commit-bot: I haz the power, 2016-03-04 19:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 19:55:36]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-04 21:07:39]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-04 21:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/1749383002/#ps100001
(title: "Resurrect obj-c callback invoked by OS X system framework")

[commit-bot: I haz the power, 2016-03-04 21:08:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/100001

[commit-bot: I haz the power, 2016-03-04 21:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:16:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2016-03-07 11:56:49]

btw, can you please update the CL description to have a <80c summary in the
first line, and be <80c in general

[Mark Dittmer, 2016-03-07 14:35:14]

rebase

[Mark Dittmer, 2016-03-07 14:35:36]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 14:35:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/120001

[commit-bot: I haz the power, 2016-03-07 16:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 16:05:57]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-07 17:01:37]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-07 17:01:37]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1749383002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-07 17:02:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749383002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749383002/120001

[commit-bot: I haz the power, 2016-03-07 17:09:49]

Description was changed from

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
==========

to

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
==========

[commit-bot: I haz the power, 2016-03-07 17:09:51]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-07 17:11:03]

Description was changed from

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072
==========

to

==========
Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl
through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by
blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like
willEndLiveResize) and state (that tracks whether currently live resizing).

BUG=591072

Committed: https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8
Cr-Commit-Position: refs/heads/master@{#379568}
==========

[commit-bot: I haz the power, 2016-03-07 17:11:05]

Patchset 7 (id:??) landed as
https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8
Cr-Commit-Position: refs/heads/master@{#379568}