Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1749383002: Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 #else 145 #else
146 deref(); // Balances ref() acquired in WebFrameWidget::create 146 deref(); // Balances ref() acquired in WebFrameWidget::create
147 #endif 147 #endif
148 } 148 }
149 149
150 WebSize WebFrameWidgetImpl::size() 150 WebSize WebFrameWidgetImpl::size()
151 { 151 {
152 return m_size; 152 return m_size;
153 } 153 }
154 154
155 void WebFrameWidgetImpl::willStartLiveResize()
156 {
157 if (m_localRoot->frameView())
158 m_localRoot->frameView()->willStartLiveResize();
159 }
160
161 void WebFrameWidgetImpl::resize(const WebSize& newSize) 155 void WebFrameWidgetImpl::resize(const WebSize& newSize)
162 { 156 {
163 if (m_size == newSize) 157 if (m_size == newSize)
164 return; 158 return;
165 159
166 FrameView* view = m_localRoot->frameView(); 160 FrameView* view = m_localRoot->frameView();
167 if (!view) 161 if (!view)
168 return; 162 return;
169 163
170 m_size = newSize; 164 m_size = newSize;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 215
222 view->setLayoutSize(layoutSize); 216 view->setLayoutSize(layoutSize);
223 } 217 }
224 218
225 void WebFrameWidgetImpl::setIgnoreInputEvents(bool newValue) 219 void WebFrameWidgetImpl::setIgnoreInputEvents(bool newValue)
226 { 220 {
227 ASSERT(m_ignoreInputEvents != newValue); 221 ASSERT(m_ignoreInputEvents != newValue);
228 m_ignoreInputEvents = newValue; 222 m_ignoreInputEvents = newValue;
229 } 223 }
230 224
231 void WebFrameWidgetImpl::willEndLiveResize()
232 {
233 if (m_localRoot->frameView())
234 m_localRoot->frameView()->willEndLiveResize();
235 }
236
237 void WebFrameWidgetImpl::didEnterFullScreen() 225 void WebFrameWidgetImpl::didEnterFullScreen()
238 { 226 {
239 // FIXME: Implement full screen for out-of-process iframes. 227 // FIXME: Implement full screen for out-of-process iframes.
240 } 228 }
241 229
242 void WebFrameWidgetImpl::didExitFullScreen() 230 void WebFrameWidgetImpl::didExitFullScreen()
243 { 231 {
244 // FIXME: Implement full screen for out-of-process iframes. 232 // FIXME: Implement full screen for out-of-process iframes.
245 } 233 }
246 234
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 1093
1106 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame) 1094 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame)
1107 { 1095 {
1108 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame)); 1096 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame));
1109 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active); 1097 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
1110 result.setToShadowHostIfInUserAgentShadowRoot(); 1098 result.setToShadowHostIfInUserAgentShadowRoot();
1111 return result; 1099 return result;
1112 } 1100 }
1113 1101
1114 } // namespace blink 1102 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698