Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to…

third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

 /*
  * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 198 matching lines @@
 
 - (NSRect)contentAreaRectForScrollerImpPair:(id)scrollerImpPair
 {
     if (!_scrollableArea)
         return NSZeroRect;
 
     blink::IntSize contentsSize = _scrollableArea->contentsSize();
     return NSMakeRect(0, 0, contentsSize.width(), contentsSize.height());
 }
 
-- (BOOL)inLiveResizeForScrollerImpPair:(id)scrollerImpPair

[Stephen Chennney, 2016/03/04 17:36:56]

This is part of the implementation for BlinkScrollbarPainterControllerDelegate,
which is set up as the delegate for the NSScrollImpPair in the ScrollAnimatorMac
constructor. I don't think you can remove it - evidence suggests it is a
required part of the delagates implementation.

[Mark Dittmer, 2016/03/04 19:06:24]

Thanks. I've since added it back (with the trivial "return NO" implementation).
I'll poke around with the delegate to see whether it can be removed, but I think
you're right, probably need to keep it.

-{
-    if (!_scrollableArea)
-        return NO;
-
-    return _scrollableArea->inLiveResize();
-}
-
 - (NSPoint)mouseLocationInContentAreaForScrollerImpPair:(id)scrollerImpPair
 {
     if (!_scrollableArea)
         return NSZeroPoint;
 
     return _scrollableArea->lastKnownMousePosition();
 }
 
 - (NSPoint)scrollerImpPair:(id)scrollerImpPair convertContentPoint:(NSPoint)pointInContentArea toScrollerImp:(id)scrollerImp
 {
@@ skipping 617 matching lines @@
         return;
 
     if (ScrollbarThemeMacCommon::isOverlayAPIAvailable()) {
         if (!supportsUIStateTransitionProgress())
             return;
         if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar))
             [painter mouseExitedScroller];
     }
 }
 
-void ScrollAnimatorMac::willStartLiveResize()
-{
-    if (!scrollableArea()->scrollbarsCanBeActive())
-        return;
-    if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
-        [m_scrollbarPainterController.get() startLiveResize];
-}
-
 void ScrollAnimatorMac::contentsResized() const
 {
     if (!scrollableArea()->scrollbarsCanBeActive())
         return;
     if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
         [m_scrollbarPainterController.get() contentAreaDidResize];
 }
 
-void ScrollAnimatorMac::willEndLiveResize()
-{
-    if (!scrollableArea()->scrollbarsCanBeActive())
-        return;
-    if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
-        [m_scrollbarPainterController.get() endLiveResize];
-}
-
 void ScrollAnimatorMac::contentAreaDidShow() const
 {
     if (!scrollableArea()->scrollbarsCanBeActive())
         return;
     if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
         [m_scrollbarPainterController.get() windowOrderedIn];
 }
 
 void ScrollAnimatorMac::contentAreaDidHide() const
 {
@@ skipping 44 matching lines @@
 
     ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar);
     if (!painter)
         return;
 
     ASSERT(!m_verticalScrollbarPainterDelegate);
     m_verticalScrollbarPainterDelegate.adoptNS([[BlinkScrollbarPainterDelegate alloc] initWithScrollbar:&scrollbar]);
 
     [painter setDelegate:m_verticalScrollbarPainterDelegate.get()];
     [m_scrollbarPainterController.get() setVerticalScrollerImp:painter];
-    if (scrollableArea()->inLiveResize())
-        [painter setKnobAlpha:1];
 }
 
 void ScrollAnimatorMac::willRemoveVerticalScrollbar(Scrollbar& scrollbar)
 {
     if (!ScrollbarThemeMacCommon::isOverlayAPIAvailable())
         return;
 
     ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar);
     if (!painter)
         return;
@@ skipping 13 matching lines @@
 
     ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar);
     if (!painter)
         return;
 
     ASSERT(!m_horizontalScrollbarPainterDelegate);
     m_horizontalScrollbarPainterDelegate.adoptNS([[BlinkScrollbarPainterDelegate alloc] initWithScrollbar:&scrollbar]);
 
     [painter setDelegate:m_horizontalScrollbarPainterDelegate.get()];
     [m_scrollbarPainterController.get() setHorizontalScrollerImp:painter];
-    if (scrollableArea()->inLiveResize())
-        [painter setKnobAlpha:1];
 }
 
 void ScrollAnimatorMac::willRemoveHorizontalScrollbar(Scrollbar& scrollbar)
 {
     if (!ScrollbarThemeMacCommon::isOverlayAPIAvailable())
         return;
 
     ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar);
     if (!painter)
         return;
@@ skipping 183 matching lines @@
         return;
 
     m_visibleScrollerThumbRect = rectInViewCoordinates;
 }
 
 bool ScrollAnimatorMac::canUseCoordinatedScrollbar() {
     return ScrollbarThemeMacCommon::isOverlayAPIAvailable();
 }
 
 } // namespace blink