Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

Issue 1749383002: Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
index 6a8b62f95ca0a1e3bb8a700f1645ff50c94397c8..c9e585a53181716764b22aa3db8880a33067883f 100644
--- a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
+++ b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
@@ -122,36 +122,6 @@ public:
}
};
-TEST_F(ImageQualityControllerTest, LowQualityFilterForLiveResize)
-{
- MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
- controller()->setTimer(mockTimer);
- setBodyInnerHTML("<img src='myimage'></img>");
- LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
-
- RefPtr<TestImageLowQuality> testImage = adoptRef(new TestImageLowQuality);
-
- // Start a resize
- document().frame()->view()->willStartLiveResize();
- EXPECT_EQ(InterpolationLow, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(2, 2)));
-
- document().frame()->view()->willEndLiveResize();
-
- // End of live resize, but timer has not fired. Therefore paint at non-low quality.
- EXPECT_EQ(InterpolationMedium, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(3, 3)));
-
- // Start another resize
- document().frame()->view()->willStartLiveResize();
- EXPECT_EQ(InterpolationLow, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(3, 3)));
-
- // While still in resize, expire the timer.
- document().frame()->view()->willEndLiveResize();
-
- mockTimer->fire();
- // End of live resize, and timer has fired. Therefore paint at non-low quality, even though the size has changed.
- EXPECT_EQ(InterpolationMedium, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(4, 4)));
-}
-
TEST_F(ImageQualityControllerTest, LowQualityFilterForResizingImage)
{
MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);

Powered by Google App Engine
This is Rietveld 408576698