[Android] Revise handling of document-mode-only tests.

[Android] Revise handling of document-mode-only tests.

This forces document-only tests to run Chrome in document mode at test
set-up time, which eliminates (most of) the need for @DisableInTabbedMode.

BUG=589663
Committed: https://crrev.com/8816e34f3a7ee1cef01354e0c9ccee6798a48ff1
Cr-Commit-Position: refs/heads/master@{#378528}

[jbudorick, 2016-02-29 22:40:22]

Description was changed from

==========
[Android] Revise handling of document-mode only tests.

BUG=589663
==========

to

==========
[Android] Revise handling of document-mode-only tests.

BUG=589663
==========

[jbudorick, 2016-02-29 22:41:13]

Description was changed from

==========
[Android] Revise handling of document-mode-only tests.

BUG=589663
==========

to

==========
[Android] Revise handling of document-mode-only tests.

BUG=589663
==========

[jbudorick, 2016-03-01 00:07:51]

jbudorick@chromium.org changed reviewers:
+ newt@chromium.org, yfriedman@chromium.org

[Yaron, 2016-03-01 02:09:42]

https://codereview.chromium.org/1748853002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:581:
if (params != null && params.getTabToReparent() != null) {
why'd this change?

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeLowEndTest.java
(left):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeLowEndTest.java:24:
import org.chromium.chrome.test.util.DisableInTabbedMode;
this file will be removed when downstream ref gone? what other reason to have
it?

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java
(left):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java:48:
@DisableInTabbedMode
Ok, note to self, read bug description before reviewing - I was super confused.
I'd also recommend updating the CL description with a little more context ;)

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java
(right):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java:89:
if (mPreviouslyOptedOut) {
this is good for intra test suite but the pref file is also deleted between
suites, right?

[jbudorick, 2016-03-01 04:00:06]

Description was changed from

==========
[Android] Revise handling of document-mode-only tests.

BUG=589663
==========

to

==========
[Android] Revise handling of document-mode-only tests.

This forces document-only tests to run Chrome in document mode at test
set-up time, which eliminates (most of) the need for @DisableInTabbedMode.

BUG=589663
==========

[jbudorick, 2016-03-01 04:00:47]

https://codereview.chromium.org/1748853002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:581:
if (params != null && params.getTabToReparent() != null) {
On 2016/03/01 02:09:42, Yaron wrote:
> why'd this change?

because:
 - params was null in DocumentModeTest.testDuplicateTabIDsKillsOldActivities,
and
 - tab reparenting was added last week in
https://codereview.chromium.org/1731673002, so this seemed like a bug that was
missed by not running the tests in document mode

yusuf wound up doing this in https://codereview.chromium.org/1746933002, though,
so it's disappearing from this CL.

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeLowEndTest.java
(left):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeLowEndTest.java:24:
import org.chromium.chrome.test.util.DisableInTabbedMode;
On 2016/03/01 02:09:42, Yaron wrote:
> this file will be removed when downstream ref gone? what other reason to have
> it?

there's also a BrandColorTest that uses it
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...),
but ideally, yes.

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java
(left):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java:48:
@DisableInTabbedMode
On 2016/03/01 02:09:42, Yaron wrote:
> Ok, note to self, read bug description before reviewing - I was super
confused.
> I'd also recommend updating the CL description with a little more context ;)

added a little more context :P

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java
(right):

https://codereview.chromium.org/1748853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java:89:
if (mPreviouslyOptedOut) {
On 2016/03/01 02:09:42, Yaron wrote:
> this is good for intra test suite but the pref file is also deleted between
> suites, right?

hm, i suppose (though I hadn't thought about it). I added this just for good
hygiene - tests should restore state they modify.

[Yaron, 2016-03-01 16:29:08]

lgtm

[jbudorick, 2016-03-01 18:11:46]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-03-01 18:11:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1748853002/#ps40001
(title: "fix DocumentActivity after bad rebase in
https://codereview.chromium.org/1688603004/")

[commit-bot: I haz the power, 2016-03-01 18:12:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748853002/40001

[commit-bot: I haz the power, 2016-03-01 19:42:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-01 19:44:22]

Description was changed from

==========
[Android] Revise handling of document-mode-only tests.

This forces document-only tests to run Chrome in document mode at test
set-up time, which eliminates (most of) the need for @DisableInTabbedMode.

BUG=589663
==========

to

==========
[Android] Revise handling of document-mode-only tests.

This forces document-only tests to run Chrome in document mode at test
set-up time, which eliminates (most of) the need for @DisableInTabbedMode.

BUG=589663

Committed: https://crrev.com/8816e34f3a7ee1cef01354e0c9ccee6798a48ff1
Cr-Commit-Position: refs/heads/master@{#378528}
==========

[commit-bot: I haz the power, 2016-03-01 19:44:23]

Patchset 3 (id:??) landed as
https://crrev.com/8816e34f3a7ee1cef01354e0c9ccee6798a48ff1
Cr-Commit-Position: refs/heads/master@{#378528}