Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3889)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java

Issue 1748853002: [Android] Revise handling of document-mode-only tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix DocumentActivity after bad rebase in https://codereview.chromium.org/1688603004/ Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
index 45b951a6d06454a61759e112c7114b35c9993bc5..80b9d30cce0a628b40d7a6c350a19cb15ac398a2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
@@ -10,6 +10,7 @@ import android.os.Build;
import android.preference.PreferenceManager;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.VisibleForTesting;
import java.util.Locale;
@@ -19,14 +20,13 @@ import java.util.Locale;
public class DocumentModeManager {
public static final String OPT_OUT_STATE = "opt_out_state";
+ public static final int OPT_OUT_STATE_UNSET = -1;
+ public static final int OPT_IN_TO_DOCUMENT_MODE = 0;
public static final int OPT_OUT_PROMO_DISMISSED = 1;
public static final int OPTED_OUT_OF_DOCUMENT_MODE = 2;
public static final String OPT_OUT_SHOWN_COUNT = "opt_out_shown_count";
public static final String OPT_OUT_CLEAN_UP_PENDING = "opt_out_clean_up_pending";
- private static final int OPT_OUT_STATE_UNSET = -1;
- private static final int OPT_IN_TO_DOCUMENT_MODE = 0;
-
// Taken from https://support.google.com/googleplay/answer/1727131?hl=en-GB
private static final String[] DEFAULT_TABBED_MODE_DEVICES = {
"GT-I9505G", // Galaxy S4 Google Play Edition
@@ -269,4 +269,9 @@ public class DocumentModeManager {
}
return optOutState;
}
+
+ @VisibleForTesting
+ public int getOptOutStateForTesting() {
+ return mSharedPreferences.getInt(OPT_OUT_STATE, OPT_OUT_STATE_UNSET);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698