base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java - Issue 1748853002: [Android] Revise handling of document-mode-only tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java

Issue 1748853002: [Android] Revise handling of document-mode-only tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix DocumentActivity after bad rebase in https://codereview.chromium.org/1688603004/ Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java ('k') | base/test/android/javatests/src/org/chromium/base/test/util/MinAndroidSdkLevel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java

diff --git a/base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java b/base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java

index 1de03ac79834e0b24aa940c8d1e129986460e8bb..7e31a5d46e31f4f61bd4dabd7cf8dbbbab22cdb9 100644

--- a/base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java

+++ b/base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java

@@ -106,6 +106,8 @@ public class BaseTestResult extends TestResult {

@Override

protected void run(TestCase test) {

+ runPreTestHooks(test);

if (shouldSkip(test)) {

startTest(test);

@@ -117,8 +119,6 @@ public class BaseTestResult extends TestResult {

endTest(test);

} else {

- runPreTestHooks(test);

if (test instanceof Parameterizable) {

try {

runParameterized(test);