Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1746933002: Check if asyncparams is null for document mode UI initialization (Closed)

Created:
4 years, 9 months ago by Yusuf
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if asyncparams is null for document mode UI initialization The if statement checks for the tabtobereparented to be null without checking the params itself. BUG=590637 Committed: https://crrev.com/12b7f87c4b5a6dd07bbb3c75166dbba770579fb2 Cr-Commit-Position: refs/heads/master@{#378249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yusuf
4 years, 9 months ago (2016-02-29 19:08:17 UTC) #2
Ted C
lgtm
4 years, 9 months ago (2016-02-29 19:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746933002/1
4 years, 9 months ago (2016-02-29 19:16:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 20:01:10 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:02:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12b7f87c4b5a6dd07bbb3c75166dbba770579fb2
Cr-Commit-Position: refs/heads/master@{#378249}

Powered by Google App Engine
This is Rietveld 408576698