src/IceInst.h - Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.h

Issue 1741733003: Fix clang warning "has virtual functions but non-virtual destructor". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.h

diff --git a/src/IceInst.h b/src/IceInst.h

index 9daf8e2644345e534b861e4280a2bcb4948aecfb..6c62d0bcaff73ee9cd55b24d05d869dbd2252bec 100644

--- a/src/IceInst.h

+++ b/src/IceInst.h

@@ -165,7 +165,7 @@ public:

void dumpDest(const Cfg *Func) const;

virtual bool isRedundantAssign() const { return false; }

- ~Inst() = default;

+ virtual ~Inst() = default;

protected:

Inst(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest);

« no previous file with comments | « src/IceFixups.h ('k') | src/IceOperand.h » ('j') | no next file with comments »