Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1740103002: Silence shift-negative-value warnings only on POSIX/Clang. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Silence shift-negative-value warnings only on POSIX/Clang. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8ba5b59356d506d3b9e976e7422e69bbd5bec8d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M third_party/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/third_party.gyp View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-26 08:06:45 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-26 17:00:00 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-26 20:33:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ba5b59356d506d3b9e976e7422e69bbd5bec8d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698