Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: third_party/BUILD.gn

Issue 1740103002: Silence shift-negative-value warnings only on POSIX/Clang. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/third_party.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/BUILD.gn
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index 933e92a2acf3784ce08febcfb6fe47d3407a592e..92fbcaa9fb88e575bbef28d13eb94de319b07374 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -179,7 +179,9 @@ source_set("fx_lcms2") {
# This is only used for standalone builds.
config("jpeg_warnings") {
visibility = [ ":*" ]
- cflags = [ "-Wno-shift-negative-value" ]
+ if (is_clang) {
+ cflags = [ "-Wno-shift-negative-value" ]
+ }
}
source_set("jpeg") {
@@ -364,7 +366,9 @@ if (pdf_enable_xfa) {
# TODO(dsinclair): Remove if fixed upstream. https://crbug.com/507712
config("fx_zlib_warnings") {
visibility = [ ":*" ]
- cflags = [ "-Wno-shift-negative-value" ]
+ if (is_clang) {
+ cflags = [ "-Wno-shift-negative-value" ]
+ }
}
source_set("fx_zlib") {
« no previous file with comments | « no previous file | third_party/third_party.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698