Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/BUILD.gn

Issue 1740103002: Silence shift-negative-value warnings only on POSIX/Clang. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/third_party.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 PDFium Authors. All rights reserved. 1 # Copyright 2014 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../pdfium.gni") 5 import("../pdfium.gni")
6 6
7 group("third_party") { 7 group("third_party") {
8 deps = [ 8 deps = [
9 ":bigint", 9 ":bigint",
10 ":fx_freetype", 10 ":fx_freetype",
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 "lcms2-2.6/src/cmstypes.c", 172 "lcms2-2.6/src/cmstypes.c",
173 "lcms2-2.6/src/cmsvirt.c", 173 "lcms2-2.6/src/cmsvirt.c",
174 "lcms2-2.6/src/cmswtpnt.c", 174 "lcms2-2.6/src/cmswtpnt.c",
175 "lcms2-2.6/src/cmsxform.c", 175 "lcms2-2.6/src/cmsxform.c",
176 ] 176 ]
177 } 177 }
178 178
179 # This is only used for standalone builds. 179 # This is only used for standalone builds.
180 config("jpeg_warnings") { 180 config("jpeg_warnings") {
181 visibility = [ ":*" ] 181 visibility = [ ":*" ]
182 cflags = [ "-Wno-shift-negative-value" ] 182 if (is_clang) {
183 cflags = [ "-Wno-shift-negative-value" ]
184 }
183 } 185 }
184 186
185 source_set("jpeg") { 187 source_set("jpeg") {
186 configs -= [ "//build/config/compiler:chromium_code" ] 188 configs -= [ "//build/config/compiler:chromium_code" ]
187 configs += [ 189 configs += [
188 "//build/config/compiler:no_chromium_code", 190 "//build/config/compiler:no_chromium_code",
189 "//third_party/pdfium:pdfium_config", 191 "//third_party/pdfium:pdfium_config",
190 192
191 # Must be after no_chromium_code for warning flags to be ordered correctly. 193 # Must be after no_chromium_code for warning flags to be ordered correctly.
192 ":jpeg_warnings", 194 ":jpeg_warnings",
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 "libtiff/tif_warning.c", 359 "libtiff/tif_warning.c",
358 "libtiff/tif_write.c", 360 "libtiff/tif_write.c",
359 "libtiff/tif_zip.c", 361 "libtiff/tif_zip.c",
360 ] 362 ]
361 } 363 }
362 } 364 }
363 365
364 # TODO(dsinclair): Remove if fixed upstream. https://crbug.com/507712 366 # TODO(dsinclair): Remove if fixed upstream. https://crbug.com/507712
365 config("fx_zlib_warnings") { 367 config("fx_zlib_warnings") {
366 visibility = [ ":*" ] 368 visibility = [ ":*" ]
367 cflags = [ "-Wno-shift-negative-value" ] 369 if (is_clang) {
370 cflags = [ "-Wno-shift-negative-value" ]
371 }
368 } 372 }
369 373
370 source_set("fx_zlib") { 374 source_set("fx_zlib") {
371 configs -= [ "//build/config/compiler:chromium_code" ] 375 configs -= [ "//build/config/compiler:chromium_code" ]
372 configs += [ 376 configs += [
373 "//build/config/compiler:no_chromium_code", 377 "//build/config/compiler:no_chromium_code",
374 "//third_party/pdfium:pdfium_config", 378 "//third_party/pdfium:pdfium_config",
375 379
376 # Must be after no_chromium_code for warning flags to be ordered correctly. 380 # Must be after no_chromium_code for warning flags to be ordered correctly.
377 ":fx_zlib_warnings", 381 ":fx_zlib_warnings",
(...skipping 26 matching lines...) Expand all
404 sources = [ 408 sources = [
405 "base/logging.h", 409 "base/logging.h",
406 "base/macros.h", 410 "base/macros.h",
407 "base/numerics/safe_conversions.h", 411 "base/numerics/safe_conversions.h",
408 "base/numerics/safe_conversions_impl.h", 412 "base/numerics/safe_conversions_impl.h",
409 "base/numerics/safe_math.h", 413 "base/numerics/safe_math.h",
410 "base/numerics/safe_math_impl.h", 414 "base/numerics/safe_math_impl.h",
411 "base/stl_util.h", 415 "base/stl_util.h",
412 ] 416 ]
413 } 417 }
OLDNEW
« no previous file with comments | « no previous file | third_party/third_party.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698