Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: third_party/third_party.gyp

Issue 1740103002: Silence shift-negative-value warnings only on POSIX/Clang. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/third_party.gyp
diff --git a/third_party/third_party.gyp b/third_party/third_party.gyp
index 0208fa14e37a9ddd2c47c25abde56cd9e3368a42..6746230f1d8a557b04d62347b53e711ccdf8f444 100644
--- a/third_party/third_party.gyp
+++ b/third_party/third_party.gyp
@@ -230,14 +230,12 @@
'libjpeg/jversion.h',
'libjpeg/transupp.h',
],
- 'cflags': [
- '-Wno-shift-negative-value',
- ],
'conditions': [
['os_posix==1', {
'cflags': [
'-Wno-main',
'-Wno-missing-braces',
+ '-Wno-shift-negative-value',
'-Wno-unused',
],
}],
@@ -316,9 +314,13 @@
'zlib_v128/uncompr.c',
'zlib_v128/zutil.c',
],
- 'cflags': [
- # TODO(dsinclair): Remove if fixed upstream. https://crbug.com/507712
- '-Wno-shift-negative-value',
+ 'conditions': [
+ ['os_posix==1', {
+ 'cflags': [
+ # TODO(dsinclair): Remove if fixed upstream. https://crbug.com/507712
+ '-Wno-shift-negative-value',
+ ],
+ }],
],
},
« no previous file with comments | « third_party/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698